Previous Thread
Next Thread
Print Thread
Rate Thread
#101521 10/22/2000 9:09 PM
Joined: Sep 2000
Posts: 755
P.I.T.A. / Programmer
P.I.T.A. / Programmer
Offline
Joined: Sep 2000
Posts: 755
I can tell you right now it won't work.

param() is a CGI.pm function and thusly (since the OO method is being used) all references to param() need to be written as $q->param(). I see at least 6 instances where it is wrong.

Not to mention that:

open("USER",param(user).'.cgi') || die ("Can't Regester you: $! ");

is:
1) a security hole the size of Texas.
2) written incorrectly anyway. USER should not be in quotes, and it is preferable to use 'or' instead of '||' in this situation.

Plus, I see calls to subroutines called lock and unlock (lock being called AFTER information is read in from the file, which is pointless..), yet neither of them appear in the file, nor are any other files require()ed in.

Not recommended that you or anyone else put this on a live server.

--mark

This message has been edited by Mark Badolato on October 22, 2000 at 09:10 PM


"Annnnnnnndd now, opening for Iron Maiden...... WYLD STALLYNS!!!" --Bill S. Preston, Esquire and Ted "Theodore " Logan
Sponsored Links
Entire Thread
Subject Posted By Posted
A registering script Em8 10/23/2000 2:52 AM
Re: A registering script Mark Badolato 10/23/2000 4:09 AM
Re: A registering script Em8 10/24/2000 12:05 AM
Re: A registering script Mark Badolato 10/24/2000 1:32 AM
Re: A registering script Melchus 10/24/2000 3:23 AM
Re: A registering script zanardi 10/24/2000 4:35 PM
Re: A registering script Mark Badolato 10/24/2000 5:30 PM
Re: A registering script Em8 10/25/2000 12:27 AM
Re: A registering script Em8 10/25/2000 2:20 AM
Re: A registering script Melchus 10/25/2000 4:05 AM

Link Copied to Clipboard
Donate Today!
Donate via PayPal

Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.

Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
Recommended Hosts
We have personally worked with and recommend the following Web Hosts:
• Shock Hosting
• Stable Host
• bluehost
• InterServer
Visit us on Facebook
Member Spotlight
JAISP
JAISP
PA
Posts: 449
Joined: February 2008
Forum Statistics
Forums63
Topics37,583
Posts293,957
Members13,826
Most Online151,614
Nov 14th, 2025
Today's Statistics
Currently Online 4025
Topics Created 0
Posts Made 0
Users Online 0
Birthdays 29
Top Posters
AllenAyres 21,080
JoshPet 10,369
LK 7,394
Lord Dexter 6,708
Gizmo 5,834
Greg Hard 4,625
Top Posters(30 Days)
isaac 2
Top Likes Received
isaac 82
Gizmo 20
Brett 7
WebGuy 2
Morgan 2
Top Likes Received (30 Days)
None yet
The UBB.Developers Network (UBB.Dev/Threads.Dev) is ©2000-2026 VNC Web Services

 
Powered by UBB.threads™ PHP Forum Software 8.1.0
(Snapshot build 20261026)