|
|
Joined: May 2000
Posts: 1,356
Addict
|
Addict
Joined: May 2000
Posts: 1,356 |
hmm... seems fine to me, however I have some suggestions: my $pm_user_exists = 0; foreach $psn (@thegoodguys) { if ($psn eq $pm_command[1]) { $pm_user_exists = 1; } } if ($pm_user_exists ne '1') { $mymsg = &html(qq~<b>$pm_command[1]</b> is not a registered Member of TPMBot.~); goto PMNOUSERNAME; } can be my $pm_user_exists = 0; foreach $psn (@thegoodguys) { if ($psn eq $pm_command[1]) { $pm_user_exists = 1; last; # so that if we have a match at the beginnig, # we dont waste our time with an unnecessary loop } } if ($pm_user_exists != 1) {# for numbers, always use numerical operators... $mymsg = &html(qq~<b>$pm_command[1]</b> is not a registered Member of TPMBot.~); goto PMNOUSERNAME; } PMNOUSERNAME: $nothing = '1'; can be (must be!) PMNOUSERNAME: $nothing = 1;
|
|
|
Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.
Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
|
|
Posts: 417
Joined: November 2001
|
|
Forums63
Topics37,575
Posts293,930
Members13,823
|
Most Online6,139 Sep 21st, 2024
|
|
Currently Online
Topics Created
Posts Made
Users Online
Birthdays
|
|
|
|
|