Joined: Apr 2001
Posts: 96
Power User
Power User
Joined: Apr 2001
Posts: 96
Could you paste me exactly what you put in the ubbcode block for the spoiler tag? What it looks like is that you're missing the ),
All I did was type
The error came up in Post Preview - I never actually posted it. Not sure if that makes a difference...
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
well, the error is with the ubbcode insert in the lib file; i need to know exactly what you inserted to troubleshoot it lol
Joined: Apr 2001
Posts: 96
Power User
Power User
Joined: Apr 2001
Posts: 96
Sorry, I misunderstood what you were asking
I put this in libs/ubbthreads.inc.php, the same code you provided, after the email line as directed:
And not only do I get the following error, but it prevents the entire forum from loading up. I get a white screen with:
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
I'm certainly hoping you're posting the content of your file vs the first post in this thread lol...
Joined: Apr 2001
Posts: 96
Power User
Power User
Joined: Apr 2001
Posts: 96
Of course I copied/pasted it from my file - lol - but I'll email it to you anyway...
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Gizmo,
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Found the error. You were missing the escape characters for the added "class" part.
Should be:
array( "#\[spoiler\](.+?)\[/spoiler\]#i", "<div class=\"ubbcode-block\"><div class=\"ubbcode-header\">Warning, Spoiler: <input type=\"button\" class=\"form-button\" value=\"Show\" onclick=\"if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.innerText = ''; this.value = 'Hide'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerText = ''; this.value = 'Show'; }\" /></div><div class=\"ubbcode-body\"><div style=\"display: none;\">\\1</div></div></div>" ), Fred
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Hmmm, I added everything like in the instructions, but I can't get the window to "popup."
I did change void(x) to void (0) to match the others as in:
<a href="javascript: void(0)" onclick="DoPrompt('spoiler');" title="Spoiler" alt="Spoiler"><img id="spoiler" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/spoiler.gif" /></a> Still no dice.
Joined: Apr 2001
Posts: 96
Power User
Power User
Joined: Apr 2001
Posts: 96
Good eye, Fred! Mine's working properly now...
It was the
class="form-button" missing the slashes...
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Are you using the markup panel? I have gotten the spoiler part to work, but not the markup panel. It shows the button, will highlight it and when you mouse over it, it says "spoiler" and at the bottom (status bar) you can see where it will call javascript like the others, but when you click the button nothing happens.
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Weird, I had to exit out of IE all together and come back and now the spoiler button is working...
Joined: Apr 2001
Posts: 96
Power User
Power User
Joined: Apr 2001
Posts: 96
No, I didn't include it in the markup panel, but glad yours is working now...
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Oh, one more FYI, the gif file is about 1 or 2 pixels too big (tall-height).
Attachments
Last edited by Fred Johnson; 03/19/2007 4:19 PM .
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
The markup panel addon should work, i tested it like once then removed it from my board.
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
Ok, first post updated.
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Gizmo,
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
I don't see how it'd happen actually, could you link me to an example of this?
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Sent you a PM.
Can someone else with this mod installed post a spoiler in a topic and then try to edit their post?
Does it let you?
Fred
Last edited by Fred Johnson; 03/19/2007 6:03 PM .
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
Allows me just fine on 3 installs, hence why i dont see why this would error...
Joined: Apr 2001
Posts: 96
Power User
Power User
Joined: Apr 2001
Posts: 96
No problems here. It's a tag like any other, so doesn't make sense to me, either...
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
I can't see how it COULD mess with the edit post timer (the erorr is generated from that), all this mod does is insert html/ubbcode into the database which any post-based mod would do... The worse that could occour would be that the connection to the server died mid-packet and not all html was inserted; which would be near impossible and woudln't be related lol...
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
After digging further we discovered that Fred's issues derived from a separate issue which was in no part related to this modification.
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Yep,
Gizmo sure is a trooper! He logged into my site and saw I wasn't nuts, well at least that something was wrong.
I backed out all of the mods and I was still having the problem so I then went a little deeper and remembered that earlier today I had made a code change listed on the main UBB site for a v7.1.1 fix. I usually read the fixes, try them out and update my code as Rick lists them, but this one is what broke the page. I'll have to tell him about it (tomorrow, it's late now).
Anyway, this mod works great, you should try it, it is a neat feature (not sure why it isn't here yet?).
Fred
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
Oh, it will be here
... just you wait hehe...
And yeh, if you applied a fix schedualed for 7.1.1 then you definitely should report it; odd that it b0ged things this badly though lol...
Joined: Apr 2001
Posts: 96
Power User
Power User
Joined: Apr 2001
Posts: 96
Fine, don't tell the rest of us what conflicted with it...
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
According to Fred, it was one of the proposed 7.1.1 fixes at UBBCentral; he'll be making a post about it there later on today.
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
To be specific it was the modify.inc.php one where on line 94 you change the T2 to a T1. Don't do it...
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
But, that makes me want to do it...
Joined: Jul 2006
Posts: 21
Junior Member
Junior Member
Joined: Jul 2006
Posts: 21
Then do it, but don't.
How's that?
I guess you could call it a "feature." Only the topic generator can edit a post in the topic for x amount of minutes...
Joined: Nov 2001
Posts: 29
User
User
Joined: Nov 2001
Posts: 29
But, that makes me want to do it...
/agree Now I HAVE to try it! lol
Joined: Nov 2001
Posts: 29
User
User
Joined: Nov 2001
Posts: 29
What about spoilers based on User Group? j/k
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
Lol that could be interesting; not sure how it'd work lol, but interesting none the less...
Joined: Apr 2001
Posts: 96
Power User
Power User
Joined: Apr 2001
Posts: 96
Just to boost your ego a bit...
I like it Geoff!!
Great idea!!
Thanks for making me look good!
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
haha, makes me feel much better today! (sick as a dog)
Joined: Nov 2003
Posts: 482
Enthusiast
Enthusiast
Joined: Nov 2003
Posts: 482
i must echo the sentiments.. spoiler mod is sooooo much of a great idea!!
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
ps: should put this mod in the core :2c:
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
I added code which would allow users to specify a warning; it can come quite helpful if they wanted something other than the generic "Warning, Spoiler", they could have "Chapter 6, Title" and have it run into the spoiler.
To allow users to specify their own warning :
In libs/ubbthreads.inc.php, add after the [spoiler] tag set:
array( "#\(.+?)\[/spoiler\]#i", "<div class=\"ubbcode-block\"><div class=\"ubbcode-header\">\\1 <input type=\"button\" class=\"form-button\" value=\"{$ubbt_lang['SPOILER_SHOW']}\" onclick=\"if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.innerText = ''; this.value = '{$ubbt_lang['SPOILER_HIDE']}'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerText = ''; this.value = '{$ubbt_lang['SPOILER_SHOW']}'; }\" /></div><div class=\"ubbcode-body\"><div style=\"display: none;\">\\2</div></div></div>" ),
Usage Instructions :
[spoiler=This will be the warning]This text will be hidden
Joined: Nov 2003
Posts: 482
Enthusiast
Enthusiast
Joined: Nov 2003
Posts: 482
hrm, i wonder where that idea came from..
glad you added it
Joined: Jan 2000
Posts: 5,833
Likes: 20
UBBDev / UBBWiki OwnerTime Lord
UBBDev / UBBWiki OwnerTime Lord
Joined: Jan 2000
Posts: 5,833
Likes: 20
Well, it's been in for quite a while (in my bbcode that I transfer everywhere), I just adapted it for UBB7.2 and mailed it to Rick for 7.2 but it didn't get in :tear:
Joined: Jan 2011
Posts: 3
Lurker
Lurker
Joined: Jan 2011
Posts: 3
It is too good for those users who are not well knowledge about UBB Spoiler Tags. You can get entire information which you want. Thank you
VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
Posts:
417
Joined: November 2001
Forums63
Topics37,575
Posts293,930
Members13,823
Most Online6,139Sep 21st, 2024
Currently Online
Topics Created
Posts Made
Users Online
Birthdays
... just you wait hehe...
Great idea!!
