Help with Javascript function?

OK, so I've been working on 'windowshading' categories, and I got it to work, so now I'm trying to write a function to eliminate redundant code. So far what I have is...

Code

	function switchem(catnumber, hidden) {
		// Switch the visibility of categories	
		var imgmini = "CATEGORY" + catnumber + "-bulb";
		var imgexp  = "CATEGORY" + catnumber + "-hidden";
		var catname = "CATEGORY" + catnumber;

		var workaround = document.getElementById(catname);
		
		if(hidden != "yes") {
			document.getElementById(catname).style.display = "none";
			document.getElementById(imgmini).style.display = "none";
			document.getElementById(imgexp).style.display = "";
		} else {
			document.getElementById(catname).style.display = "";
			document.getElementById(imgmini).style.display = "";
			document.getElementById(imgexp).style.display = "none";
		}
	}

as the function, where the category id is "CATEGORY" plus the number.

and then the actual code I use is...

Code

<a href="javascript:switchem('$catarray->[2]', 'yes');"><div id="CATEGORY$catarray->[2]-bulb" style="float: right;">$minicat</div></a>
<a href="javascript:switchem('$catarray->[2]', 'no');"><div id="CATEGORY$catarray->[2]-hidden" style="float: right;">$expcat</div></a>
 <a href="$ULTIMATEBB?category=$catarray->[2]"><font class="categoryheader"><b>$catarray->[1]</b></font></a>
$desc
<script type="text/javascript">
<!--
	document.getElementById('CATEGORY$catarray->[2]-hidden').style.display = 'none';
	document.getElementById('CATEGORY$catarray->[2]-bulb').style.display = '';
//-->
</script>

(that last part of the javascript is so the correct bulb shows by default)

I don't get any java errors, however it's not hiding/showing the categories. Can anyone see what I've done wrong?

Add { } around the PHP arrays:

Code

<a href="javascript:switchem('{$catarray->[2]}', 'yes');"><div id="CATEGORY{$catarray->[2]}-bulb" style="float: right;">$minicat</div></a>
<a href="javascript:switchem('{$catarray->[2]}', 'no');"><div id="CATEGORY{$catarray->[2]}-hidden" style="float: right;">$expcat</div></a>
 <a href="$ULTIMATEBB?category={$catarray->[2]}"><font class="categoryheader"><b>{$catarray->[1]}</b></font></a>

Try that and see if it makes a difference.

well those are perl arrays, and I fixed it somehow by just rewriting it, dunno what changed