UBB.Dev
Posted By: Gizmo [7.x] UBB Spoiler Tags - 02/13/2007 2:33 AM
NOTE: Spoiler Tags are included in UBB.Threads 7.2.

Author: Gizmo (James of VNC Web Design)

Requirements:
  • Valid UBB.Threads 7.0 install and license


About:
This UBBCode will allow you to hide text in posts from users unless they choose to view it; thus allowing users to post movie, news, etc, spoilers and not have to ruin everyones fun!

Demo:
Please see the attached images:
2361-spoiler-closed.jpg - What people see before the spoiler is revealed.
2362-spoiler-open.jpg - What people see after the spoiler is revealed.

You can also see it in action here.

Install Instructions:
Open libs/ubbthreads.inc.php
Find:
Code
			array( "#\[email:([+_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,4}))\](.+?)\[/email]#i", '<a href="mailto:\1">\5</a>' ),

Add Under:
Code
			array( "#\[spoiler\](.+?)\[/spoiler\]#i", "<div class=\"ubbcode-block\"><div class=\"ubbcode-header\">Warning, Spoiler: <input type=\"button\" class=\"form-button\" value=\"Show\" onclick=\"if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.innerText = ''; this.value = 'Hide'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerText = ''; this.value = 'Show'; }\" /></div><div class=\"ubbcode-body\"><div style=\"display: none;\">\\1</div></div></div>" ),

IF you want to add this to the markup panel on the "Full Reply"/"Topic Creation" pages:
Code
Step 1:
Open templates/default/standardtext_editor.tpl
Find:
<a href="javascript: x()" onclick="DoPrompt('image');" title="{$lang.IMAGE_ALT}" alt="{$lang.IMAGE_ALT}"><img id="image" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/image.gif" /></a>

Add Under:
<a href="javascript: x()" onclick="DoPrompt('spoiler');" title="Spoiler" alt="Spoiler"><img id="spoiler" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/spoiler.gif" /></a>

Step 2:
Open ubb_js/standard_text_editor.js
Find:
if (action == "image") {
var thisImage = prompt(enterImage, "http://");
if (thisImage == null){return;}

insertAtCaret(document.replier.Body, ' ' + "[img]" + thisImage + "[/img]" + ' ' );
document.replier.texteditor.focus();
return;
}

Add Under:
if (action == "spoiler") {
var thisSpoiler = prompt("Enter Spoiler", "");
if (thisSpoiler == null){return;}

insertAtCaret(document.replier.Body, ' ' + "
" + thisSpoiler + "
" + ' ' );
document.replier.texteditor.focus();
return;
}

Step 3:
You'll need to insert a spoiler.gif into your markup panel directory, I am appending one supplied by Cuervo.

To filter spoilers out of the ActiveTopics system, simply:
Open scripts/activetopics.inc.php
Find:
Code
		$topics[$i]['forum_id'] = $forum_id;

Add Above:
Code
		$post_body = preg_replace('/\[spoiler\](.*?)\[\/spoiler\]/si', '', $post_body);
$post_body = preg_replace('/<div class="ubbcode-block"><div class="ubbcode-header">(.*?)<\/div><div class="ubbcode-body"><div style="display: none;">(.*?)<\/div><\/div><\/div>/si', '', $post_body);

To allow users to specify their own warning:
In libs/ubbthreads.inc.php, add after the [spoiler] tag set:
Code
			array( "#\
((.+?)\)
(.+?)\[/spoiler\]#i", "<div class=\"ubbcode-block\"><div class=\"ubbcode-header\">\\1 <input type=\"button\" class=\"form-button\" value=\"{$ubbt_lang['SPOILER_SHOW']}\" onclick=\"if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.innerText = ''; this.value = '{$ubbt_lang['SPOILER_HIDE']}'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerText = ''; this.value = '{$ubbt_lang['SPOILER_SHOW']}'; }\" /></div><div class=\"ubbcode-body\"><div style=\"display: none;\">\\2</div></div></div>" ),

Usage Instructions:
Code
[spoiler]This text will be hidden
(This will be the warning)
This text will be hidden

NOTE:
Every time a user visits the page, the spoiler text will be hidden again. Also, multi-level spoilers are not a possibility yet; I'll make that the next project wink. Additionally, the classes used are the standard ubb-code ones.

Attached picture 2361-spoiler-closed.jpg
Attached picture 2362-spoiler-open.jpg
Attached picture 2369-spoiler.gif
Attached picture 2376-spoiler.gif
Posted By: gliderdad Re: [7.x] UBB Spoiler Tags - 02/13/2007 2:42 AM
Cool Thanks Giz :wave:
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 02/13/2007 3:52 AM
If you've already applied this, please update the spoiler ubbcode; there was a bug which would not allow you to quote users when they had a spoiler lol...

And yes, it was some lingering test code wink...
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 02/13/2007 3:55 AM
by the way, this also fixed multi-level spoilers lol...

By multi level I mean:
Code
[spoiler][spoiler][spoiler]we hide!
[/spoiler][/spoiler][/spoiler]
Posted By: Firstone Re: [7.x] UBB Spoiler Tags - 02/13/2007 5:51 AM
Just awesome! Thanks a lot Gizmo smile

(I hope Rick find it usefull too ... laugh )
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 02/13/2007 5:58 AM
Not a problem... I'm hoping we can get it sneeked into a release as official-ness :crosses fingers:
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/02/2007 3:19 PM
Any chance of making this a markup panel button with a pop up?
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/03/2007 2:15 AM
I'll look it up later; in all honesty i had no plans of it being in the markup panel so i never bothered; though if it's wanted i'll poke hehe
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/03/2007 10:23 AM
Most of my users are very bright when it comes to hand typing uBBcode and it is a nice mod!
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/03/2007 10:32 AM
Completely untested, and taken from the youtube bbcode addon:
Code
[STEP 1:]
/templates/default/standard_text_editor.tpl

>>FIND
<a href="javascript: x()" onclick="DoPrompt('image');" title="{$lang.IMAGE_ALT}" alt="{$lang.IMAGE_ALT}"><img id="image" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/image.gif" /></a>

>>ADD BELOW
<a href="javascript: x()" onclick="DoPrompt('spoiler');" title="spoiler" alt="spoiler"><img id="spoiler" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/spoiler.gif" /></a>



[STEP 2:]
/ubb_js/standard_text_editor.js

>>FIND
if (action == "image") {
var thisImage = prompt(enterImage, "http://");
if (thisImage == null){return;}

insertAtCaret(document.replier.Body, ' ' + "[img]" + thisImage + "[/img]" + ' ' );
document.replier.texteditor.focus();
return;
}

>>ADD BELOW
if (action == "spoiler") {
var thisSpoiler = prompt("Enter Spoiler Data", "Spoiler Text");
if (thisVideo == null){return;}

insertAtCaret(document.replier.Body, ' ' + "
" + thisSpoiler + "
" + ' ' );
document.replier.texteditor.focus();
return;
}

[STEP 3:]
Upload gif to markup panel directory
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/04/2007 2:45 PM
Gizmo,

Should I remove the other spoiler mod stuff before adding this in?

And I guess a Monkey Speak No Evil would make a good spoiler gif.
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/04/2007 11:31 PM
The "other spoiler stuff" is the code tags in the lib files; those are completely seperate; the stuff i posted above for the editor is just the javascript that creates the editor entries. Youll slso need to put some sort of spoiler image, wasn't sure what to include...
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/05/2007 3:10 PM
So, are you saying that both of your spoiler mods must be in the code to get the markup part of it to work? Or, you can use either one by itself?
Posted By: ADWOFF Re: [7.x] UBB Spoiler Tags - 03/05/2007 8:35 PM
Giz, my man, this is way cool! smile

I especially love how you can put a spoiler within a spoiler within a spoiler ...

The only real problem I'm seeing is with Active Topics & the preview. The "spoiler" is revealed ...

~Sue
adwoff.com
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/06/2007 12:01 AM
Originally Posted by Cuervo
So, are you saying that both of your spoiler mods must be in the code to get the markup part of it to work? Or, you can use either one by itself?
I'm saying, they're both seperate...

The first, lib file addition, HAS TO BE applied for ANYTHING to work; the second, the markup panel crap, can be added IF YOU WANT it...

Sue: sub spoilers rule lol...

As for search engine, Not sure how to suppress it there... I do however believe that if spoilers are critical to your community, they should be posted wiht a description above them, as to filter them out of any search results.
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/06/2007 12:05 AM
Originally Posted by Gizmo
Originally Posted by Cuervo
So, are you saying that both of your spoiler mods must be in the code to get the markup part of it to work? Or, you can use either one by itself?
I'm saying, they're both seperate...

The first, lib file addition, HAS TO BE applied for ANYTHING to work; the second, the markup panel crap, can be added IF YOU WANT it...


Thanks, I understand now.
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/06/2007 12:07 AM
A lot of people don't care if it's in the markup panel or not, myself included; I only supplied that as a request, and quite frankly, I have no idea if it even works as I never tested it.

The other, the spoiler tags in the lib, has been heavily tested.
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/06/2007 2:04 AM
I did find something while I was trying to install this. I think the part of find:

Code
<a href="javascript: x()" onclick="DoPrompt('image');" title="{$lang.IMAGE_ALT}" alt="{$lang.IMAGE_ALT}"><img id="image" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/image.gif" /></a>

should read

Code
<a href="javascript: void(0)" onclick="DoPrompt('image');" title="{$lang.IMAGE_ALT}" alt="{$lang.IMAGE_ALT}"><img id="image" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/image.gif" /></a>

The "javascript: x() is javascript void(0)

I'm not sure on this, but it's what I found in my file.

Something of importance; when you click the markup button it brings up the add spoiler box and lets you add the text, but when you click the ok button it doesn't add the text to the post.

Any ideas on that one, Gizmo?
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/06/2007 2:49 AM
Yeh, I think some of the javascripts got updated in 7.1; the code I took the "add" line from was for 7.0.2, so it'd make sense wink... good find.

Does the markup option work? (I ask as I haven't applied it as I don't even like using the advanced editor, I mainly only use the quick reply).
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/06/2007 3:08 AM
I was testing it out just now.

It seems that once you add the text to the popup and click ok it doesn't add the text back to the post.

I'm not sure what needs to change to get the text back in there.
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/06/2007 3:50 AM
I think I found one more issue

Code
if (action == "spoiler") {
var thisSpoiler = prompt("Enter Spoiler Data", "Spoiler Text");
if (thisVideo == null){return;}

insertAtCaret(document.replier.Body, ' ' + "
" + thisSpoiler + "
" + ' ' );
document.replier.texteditor.focus();
return;
}

should read

Code

if (action == "spoiler") {
var thisSpoiler = prompt("Enter Spoiler Data", "Spoiler Text");
if (thisSpoiler == null){return;}

insertAtCaret(document.replier.Body, ' ' + "
" + thisSpoiler + "
" + ' ' );
document.replier.texteditor.focus();
return;
}

There is an instance where thisVideo should read thisSpoiler but I'm not sure if that's why it is not placing the new text in the post. /edit after further testing it appears that this is why the text was not getting posted into the message when you would click ok on the box.
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/06/2007 3:55 AM
Well after some more testing is seems the thisSpoiler was the issue.

I have everything working now.

Thanks Gizmo for doing this code bit!!

I attach the spoiler.gif file I'm using.



Attached picture 2366-spoiler.gif
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/06/2007 5:39 AM
I'm not sure, I'll give some hacking a go later...
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/06/2007 6:37 AM
I have this working:
Code
in templates/default/standardtext_editor.tpl:
<a href="javascript: x()" onclick="DoPrompt('image');" title="{$lang.IMAGE_ALT}" alt="{$lang.IMAGE_ALT}"><img id="image" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/image.gif" /></a>

Add Under:
<a href="javascript: x()" onclick="DoPrompt('spoiler');" title="Spoiler" alt="Spoiler"><img id="spoiler" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/spoiler.gif" /></a>


In ubb_js/standard_text_editor.js:
Find:
if (action == "image") {
var thisImage = prompt(enterImage, "http://");
if (thisImage == null){return;}

insertAtCaret(document.replier.Body, ' ' + "[img]" + thisImage + "[/img]" + ' ' );
document.replier.texteditor.focus();
return;
}

Add Under:
if (action == "spoiler") {
var thisSpoiler = prompt("Enter Spoiler", "");
if (thisSpoiler == null){return;}

insertAtCaret(document.replier.Body, ' ' + "
" + thisSpoiler + "
" + ' ' );
document.replier.texteditor.focus();
return;
}

You'll need to insert a spoiler.gif into your markup panel directory, I just copied the one for strikethrough
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/06/2007 6:42 AM
Original post updated with markup panel instructions.
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/06/2007 6:43 AM
BTW, totally missed your second post lol
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/06/2007 6:53 AM
I cleaned up the spoiler graphic a bit, at least it looks good with a colored background, versus having a load of white shoved into it wink
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/08/2007 7:24 AM
I added another spoiler graphic; additionally, a thought to some on this... You could adapt it as a "not safe for work" tag... I've seen some communities whine about such things wink...
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/08/2007 10:03 AM
Added a regex filter to my initial post to filter spoiler content out of Active Topics.
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/08/2007 10:12 AM
Originally Posted by Gizmo
I added another spoiler graphic; additionally, a thought to some on this... You could adapt it as a "not safe for work" tag... I've seen some communities whine about such things wink...

Another outstanding use for this mod!
Posted By: ADWOFF Re: [7.x] UBB Spoiler Tags - 03/08/2007 10:18 AM
Originally Posted by Gizmo
IF you wish to filter "spoiler content" from Active Topics:
open scripts/activetopics.inc.php
Find:
Code
		$topics[$i]['forum_id'] = $forum_id;

Add Above:
Code
		$post_body = preg_replace('/\[spoiler\](.*?)\[\/spoiler\]/si', '', $post_body);

Heya Giz~

I gave this a shot, and it did not take. frown

The spoiler part works, but it doesn't hide the text in Active Topics.

Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/08/2007 10:23 AM
Cuervo: lol i noticed somethign last night when poking around a gardening sites forum, I laughed for like 20 minutes thinking of the "inappropriate lawn gnomes" I stumbled on, and the person who was at work who opened it...

Sue: Very odd, it works on my 7.1 demo site... I'll poke in and take a gander in a bit.
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/08/2007 10:28 AM
Hmmm, seems that the active topics doesn't show the tags themselves when they're parsed (duah on my part, I can't believe I didn't think about that)...

I'll need to think, because I believe the data in the active topics doesn't take tags used into account...
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/08/2007 10:48 AM
I'm still working on the regex, I'm not sure what's wrong with it yet... It seems like something isn't parsing on it, but so far what I have is:
Code
		$post_body = preg_replace('/<div class="ubbcode-block"><div class="ubbcode-header">Warning, Spoiler: <input type="button" value="Show" (.*?) \/><\/div><div class="ubbcode-body"><div style="display: none;">(.*?)<\/div><\/div><\/div>/si', '', $post_body);

It'll at least retard the viewing of the spoiler, well, the post in general... I'll try to get it working as soon as i can figure out what i'm b0gging lol
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/08/2007 11:02 AM
Well, seems that works just fine and Ive been working on n issue which wasn't there lol... I made a couple spoiler posts to test the regex on, and turns out that the one i was working with, didn't have any other content in the post; so when it filtered the spoiler, i was going nutty lol...
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/08/2007 11:13 AM
updated initial posting:
1. New spoiler graphic.
2. Updated spoiler code, now uses the style for forum buttons.
3. Added regex entries for scripts/activetopics.inc.php to filter out all spoiler entries from the activetopics.

Also, if you want to display [spoiler] instead of no spoiler text, in the new entries in the activetopics.inc.php simply put in:
Code
		$post_body = preg_replace('/\[spoiler\](.*?)\[\/spoiler\]/si', '[spoiler]', $post_body);
$post_body = preg_replace('/<div class="ubbcode-block"><div class="ubbcode-header">(.*?)<\/div><div class="ubbcode-body"><div style="display: none;">(.*?)<\/div><\/div><\/div>/si', '[spoiler]', $post_body);

instead of
Code
		$post_body = preg_replace('/\[spoiler\](.*?)\[\/spoiler\]/si', '', $post_body);
$post_body = preg_replace('/<div class="ubbcode-block"><div class="ubbcode-header">(.*?)<\/div><div class="ubbcode-body"><div style="display: none;">(.*?)<\/div><\/div><\/div>/si', '', $post_body);
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/10/2007 1:03 PM
Originally Posted by Gizmo
Cuervo: lol i noticed somethign last night when poking around a gardening sites forum, I laughed for like 20 minutes thinking of the "inappropriate lawn gnomes" I stumbled on, and the person who was at work who opened it...

Sue: Very odd, it works on my 7.1 demo site... I'll poke in and take a gander in a bit.

I could so see someone telling their boss to come look at this site, it has a great post about growing tomatoes and woops!
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/10/2007 10:12 PM
Lol it was on topic... IT was talking about lawn gnomes haha...
Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/18/2007 2:07 AM

Giz, I'm getting this error in 7.1 (I didn't apply any of the markup panel stuff)

Parse error: syntax error, unexpected T_STRING, expecting ')' in /home2/gbb/public_html/threads/libs/ubbthreads.inc.php on line 1011
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/18/2007 3:23 AM
Could you paste me exactly what you put in the ubbcode block for the spoiler tag? What it looks like is that you're missing the ),
Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/18/2007 8:57 AM
Originally Posted by Gizmo
Could you paste me exactly what you put in the ubbcode block for the spoiler tag? What it looks like is that you're missing the ),

All I did was type
test
smirk

The error came up in Post Preview - I never actually posted it. Not sure if that makes a difference...

Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/18/2007 11:25 AM
well, the error is with the ubbcode insert in the lib file; i need to know exactly what you inserted to troubleshoot it lol
Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/18/2007 6:54 PM

Sorry, I misunderstood what you were asking blush

I put this in libs/ubbthreads.inc.php, the same code you provided, after the email line as directed:
Code

array( "#\[spoiler\](.+?)\[/spoiler\]#i", "<div class=\"ubbcode-block\"><div class=\"ubbcode-header\">Warning, Spoiler: <input type=\"button\" class="form-button" value=\"Show\" onclick=\"if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.innerText = ''; this.value = 'Hide'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerText = ''; this.value = 'Show'; }\" /></div><div class=\"ubbcode-body\"><div style=\"display: none;\">\\1</div></div></div>" ),

And not only do I get the following error, but it prevents the entire forum from loading up. I get a white screen with:
Quote

Parse error: syntax error, unexpected T_STRING, expecting ')' in /home2/gbb/public_html/threads/libs/ubbthreads.inc.php on line 1011

confused
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/18/2007 11:17 PM
I'm certainly hoping you're posting the content of your file vs the first post in this thread lol...

I don't honestly see why you'd be getting this issue; could you email me your libs/ubbthreads.inc.php so I can take a look? james[at]virtualnightclub[dot]net.
Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/19/2007 7:08 PM

Of course I copied/pasted it from my file - lol - but I'll email it to you anyway... laugh
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/19/2007 8:27 PM
Gizmo,

This looked like a cool addon so I tried it as well, I got the same error. I simply copied/pasted the one line in your first post and saved the file. I got the same error and removed it.

Fred
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/19/2007 8:33 PM
Found the error. You were missing the escape characters for the added "class" part.

Should be:
Code
array( "#\[spoiler\](.+?)\[/spoiler\]#i", "<div class=\"ubbcode-block\"><div class=\"ubbcode-header\">Warning, Spoiler: <input type=\"button\" class=\"form-button\" value=\"Show\" onclick=\"if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.innerText = ''; this.value = 'Hide'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerText = ''; this.value = 'Show'; }\" /></div><div class=\"ubbcode-body\"><div style=\"display: none;\">\\1</div></div></div>" ),

Fred
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/19/2007 10:10 PM
Hmmm, I added everything like in the instructions, but I can't get the window to "popup."

I did change void(x) to void (0) to match the others as in:
Code
<a href="javascript: void(0)" onclick="DoPrompt('spoiler');" title="Spoiler" alt="Spoiler"><img id="spoiler" onmouseover="raiseButton(this.id);" onmouseout="normalButton(this.id);" onmousedown="lowerButton(this.id);" class="markup_panel_normal_button" src="{$config.BASE_URL}/images/{$style_array.markup_panel}/spoiler.gif" /></a> 


Still no dice.
Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/19/2007 10:39 PM

Good eye, Fred! Mine's working properly now... cool
It was the class="form-button" missing the slashes...

Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/19/2007 10:46 PM
Are you using the markup panel? I have gotten the spoiler part to work, but not the markup panel. It shows the button, will highlight it and when you mouse over it, it says "spoiler" and at the bottom (status bar) you can see where it will call javascript like the others, but when you click the button nothing happens.
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/19/2007 10:57 PM
Weird, I had to exit out of IE all together and come back and now the spoiler button is working...

FYI

Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/19/2007 11:02 PM

No, I didn't include it in the markup panel, but glad yours is working now... cool


Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/19/2007 11:11 PM
Oh, one more FYI, the gif file is about 1 or 2 pixels too big (tall-height).

Edit: I removed a pixel from the top and it matches up now.

Attached picture 2375-Spoiler.gif
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/19/2007 11:21 PM
The markup panel addon should work, i tested it like once then removed it from my board.

As for the class, blaime it on me... I added that like a week or so ago and just updated it here vs taking from my live board lol... I'll update first post now...
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/19/2007 11:23 PM
Ok, first post updated.

As for the markup panel working after you closed your browser; your browser was caching the lib file.

AS for the gif being "too big", I'll get it updated to freds; the one I supplied was the ! which should be the proper size.
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/20/2007 12:22 AM
Gizmo,

Well, I thought it was all working, but I have found out that now if someone uses a spoiler tag in a post no one can edit either their post or any post in the topic (even if posted after the spoiler tag post).

Any ideas?
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/20/2007 12:40 AM
I don't see how it'd happen actually, could you link me to an example of this?
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/20/2007 12:47 AM
Sent you a PM.

Test

Can someone else with this mod installed post a spoiler in a topic and then try to edit their post?

Does it let you?

Fred
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/20/2007 1:53 AM
Allows me just fine on 3 installs, hence why i dont see why this would error...
Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/20/2007 2:32 AM

No problems here. It's a tag like any other, so doesn't make sense to me, either... confused
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/20/2007 2:41 AM
I can't see how it COULD mess with the edit post timer (the erorr is generated from that), all this mod does is insert html/ubbcode into the database which any post-based mod would do... The worse that could occour would be that the connection to the server died mid-packet and not all html was inserted; which would be near impossible and woudln't be related lol...
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/20/2007 3:23 AM
After digging further we discovered that Fred's issues derived from a separate issue which was in no part related to this modification.
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/20/2007 4:30 AM
Yep,

Gizmo sure is a trooper! He logged into my site and saw I wasn't nuts, well at least that something was wrong. whistle

I backed out all of the mods and I was still having the problem so I then went a little deeper and remembered that earlier today I had made a code change listed on the main UBB site for a v7.1.1 fix. I usually read the fixes, try them out and update my code as Rick lists them, but this one is what broke the page. I'll have to tell him about it (tomorrow, it's late now).

Anyway, this mod works great, you should try it, it is a neat feature (not sure why it isn't here yet?).

Fred
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/20/2007 4:37 AM
Oh, it will be here wink... just you wait hehe...

And yeh, if you applied a fix schedualed for 7.1.1 then you definitely should report it; odd that it b0ged things this badly though lol...
Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/20/2007 8:04 AM

Fine, don't tell the rest of us what conflicted with it... tipsy wink

Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/20/2007 12:22 PM
According to Fred, it was one of the proposed 7.1.1 fixes at UBBCentral; he'll be making a post about it there later on today.
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/20/2007 3:02 PM
To be specific it was the modify.inc.php one where on line 94 you change the T2 to a T1. Don't do it...
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/21/2007 12:11 AM
Originally Posted by Fred Johnson
Don't do it...
But, that makes me want to do it...
Posted By: Fred Johnson Re: [7.x] UBB Spoiler Tags - 03/21/2007 3:42 PM
Then do it, but don't.

How's that?

I guess you could call it a "feature." Only the topic generator can edit a post in the topic for x amount of minutes... tipsy
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/21/2007 11:20 PM
Originally Posted by Gizmo
Originally Posted by Fred Johnson
Don't do it...
But, that makes me want to do it...

/agree Now I HAVE to try it! lol
Posted By: Cuervo Re: [7.x] UBB Spoiler Tags - 03/21/2007 11:26 PM
What about spoilers based on User Group? j/k
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/22/2007 12:14 AM
Lol that could be interesting; not sure how it'd work lol, but interesting none the less...
Posted By: jgeoff Re: [7.x] UBB Spoiler Tags - 03/29/2007 9:00 PM

Just to boost your ego a bit... laugh

Quote

Those spoiler tags are the coolest things ever.
Quote

This is an AWESOME feature Geoff, thanks!
Quote

I like it Geoff!! smile Great idea!!

Thanks for making me look good! laugh wink

Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 03/30/2007 12:17 AM
haha, makes me feel much better today! (sick as a dog)
Posted By: sirdude Re: [7.x] UBB Spoiler Tags - 06/04/2007 9:55 PM
i must echo the sentiments.. spoiler mod is sooooo much of a great idea!!

thanks

ps: should put this mod in the core :2c:
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 06/05/2007 1:20 AM
Originally Posted by sirdude
ps: should put this mod in the core :2c:
wink
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 07/17/2007 5:00 AM
I added code which would allow users to specify a warning; it can come quite helpful if they wanted something other than the generic "Warning, Spoiler", they could have "Chapter 6, Title" and have it run into the spoiler.

Originally Posted by Gizmo
To allow users to specify their own warning:
In libs/ubbthreads.inc.php, add after the [spoiler] tag set:
Code
			array( "#\
((.+?)\)
(.+?)\[/spoiler\]#i", "<div class=\"ubbcode-block\"><div class=\"ubbcode-header\">\\1 <input type=\"button\" class=\"form-button\" value=\"{$ubbt_lang['SPOILER_SHOW']}\" onclick=\"if (this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = '';this.innerText = ''; this.value = '{$ubbt_lang['SPOILER_HIDE']}'; } else { this.parentNode.parentNode.getElementsByTagName('div')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerText = ''; this.value = '{$ubbt_lang['SPOILER_SHOW']}'; }\" /></div><div class=\"ubbcode-body\"><div style=\"display: none;\">\\2</div></div></div>" ),

Usage Instructions:
Code
[spoiler=This will be the warning]This text will be hidden
Posted By: sirdude Re: [7.x] UBB Spoiler Tags - 07/17/2007 3:28 PM
hrm, i wonder where that idea came from.. whistle

glad you added it wink
Posted By: Gizmo Re: [7.x] UBB Spoiler Tags - 07/18/2007 2:17 AM
Well, it's been in for quite a while (in my bbcode that I transfer everywhere), I just adapted it for UBB7.2 and mailed it to Rick for 7.2 but it didn't get in :tear:
Posted By: lysaraj Re: [7.x] UBB Spoiler Tags - 01/10/2011 9:53 AM
It is too good for those users who are not well knowledge about UBB Spoiler Tags. You can get entire information which you want. Thank you
© UBB.Developers