[6.6] [finished] Quick Reply

Author: Gizzy
Original Authors: Greg Hard and LK

Date: 09.01.2003
Requirements: Valid UBB License, UBB 6.6, Wordlets Mods

Demo: Here (see below) and just about every other UBB
Download: here

Thanks: Thanks to my little buddy Weird Al
Notes: There are only minor code modifications, and also added code for quick reply in PM's.

Thanks gizzy, one of my favorites

... I won't be doin that many ports this coming version due to me not understanding the cp and me starting a new job tomorrow...

i've redone this hack at least ten times and for some reason users can't change their choice in their profile. Mine is set to yes and I see the box. If I change it to no, it rights a 0 to line 62 (field 61 I believe) of my member file but I still see the box. When I re-enter my profile it says yes again, and if I save my profile it does in fact write a 1 to that line. I still see the box no matter what. One of the other members has the opposite problem, his is always set to no.

Any ideas?

Well, I got it to save the preference in the profile. I removed this from public_edit_profile.pl

Code

my $quickreply_yes = $user_profile[61] ne '0' ? ' checked="checked"' : '';
my $quickreply_no = $user_profile[61] eq '0' ? ' checked="checked"' : '';

Then I added this to ubb_profile.cgi

Code

# calibrate quick reply
if ($user_profile[61] eq '1') { $quickreply_yes = 'checked="checked"'; $quickreply_no = ''; }
else { $quickreply_no = 'checked="checked"'; $quickreply_yes = ''; }

after

Code

# calibrate mass mail
if ($user_profile[14] eq 'yes') { $mm_yes = 'checked="checked"'; $mm_no = ''; }
else { $mm_no = 'checked="checked"'; $mm_yes = ''; }

The bos is still ignoring the choice though. It disappears if I log out though.

try the obvious choice

change

Code

my $quickreply_yes = $user_profile[61] ne '0' ? ' checked="checked"' : '';
my $quickreply_no = $user_profile[61] eq '0' ? ' checked="checked"' : '';

to

Code

if($user_profile[61] = 1){
	my $quickreply_no = '';
	my $quickreply_yes = qq( checked="checked");
} else {
	my $quickreply_no = qq( checked="checked");
	my $quickreply_yes = '';
}

that worked for me

When I did that I get neither radio button *lit*.

then instead of = 1, try eq '1', etc

It doesn't work the same way for some people

Actually =1 doesn't work for anyone, it has to be with ==

tell me if it works and i'll update the text :x...

Quote

quote:
Originally posted by LK:
Actually =1 doesn't work for anyone, it has to be with ==

I've been coding for 7 years, I can't believe I did that

I found a bug

If you're in a private forum, and have permission to reply, but not make topics, the preview post function tells you you don't have permission

Quote

quote:
Originally posted by Weird Al:
try the obvious choice

change

Code

my $quickreply_yes = $user_profile[61] ne '0' ? ' checked="checked"' : '';
my $quickreply_no = $user_profile[61] eq '0' ? ' checked="checked"' : '';

to

Code

if($user_profile[61] = 1){
	my $quickreply_no = '';
	my $quickreply_yes = qq( checked="checked");
} else {
	my $quickreply_no = qq( checked="checked");
	my $quickreply_yes = '';
}

that worked for me

I tried this fix and it still doesn't take the quick reply out if they select no.

That wouldn't be the code I posted, that would be in the cookies. Look over the lines that resemble

Code

-value   => [$user_profile[0], md5_hex($new_password), $public_name, $daysprune, $in{u}, $pntf_hidden, $avhide, $new_date_format, $new_time_format, $tzoffset, "", "", "", $quickreply],

and if you've applied any other hacks that change it, just make sure that quick reply is the 4th one after $tzoffset. Personlly, I just don't let people disable it, then all I have to do is hide it to Anonymous users

I've verified the hack numerous times, and also verified the cookie code you posted and it still disregards the profile choice. It disappears for users that aren't logged in so I count it as a win.

I can't re-create the error with users not being able to disable the QR, or the one where it's viewable to everyone when not logged in (on 6.6).

As for the private topics where you can reply in the first place, i'll look at it a little later.

xpert, make sure the user who chose to hide quickreply has set a timezone, etc.. also don't forget to also replace "= 1" with "== 1".

Now about making QuickReply CSS savvy...

It seems that the preview button returns a permissions error in forums where the members are allowed to reply but not start threads. The error is;

Quote

quote:

FYI You do not have permission to enter this area.

Edit: the error can be duplicated in the announcements forum here.

That might be a problem in the preview code itself.

The regular reply preview works fine, do you think the code being added to the topic page itself for the quick reply is the issue?

try changing

Code

earl = earl + ";type=topic" + ";disable_smilies=" + disabled + ";Signature=" + siggy;

to

Code

earl = earl + ";type=reply" + ";disable_smilies=" + disabled + ";Signature=" + siggy;

That was it, thanks!

Ok, I went through (finally) to verify this hack on a clean version of 6.6.1.

Errors I've found that I can recreate:
Users can't turn off QR.

Errors that i cannot recreate:
QR shows when not logged in.

I'm error checking now for the best way to get it to work *as planned* and I believe Randy's route is so. Will work on other reported errors as I get time.

I don't see the QR box when logged out, I do see the first error though. I don't consider it to be a deal breaker though, it's a fantastic add-on.

Agreed, i'm tempted to take off the option to disable it, i don't know anyone who disables it in the first place lol...

I'm getting a registration error, and I think this mod might be related, could someone possibly see an error in my ubb_registration? Here is the code about where I think the problem is...

my @thismemarray = (
$user_name, $password, $email, $homepage, $permission, #0

&CensorCheck($in{occupation}), &CensorCheck($in{location}), '0', $this_status, &CensorCheck($in{interests}), #5

$GotTime{HyphenDate}, $in{EmailView}, $sig_html, $in{icq}, $in{AllowMassMail}, #10

$public_name, &CensorCheck($in{customfield1}), &CensorCheck($in{customfield2}), &CensorCheck($in{customfield3}), #15

&CensorCheck($in{customfield4}), $picture, $in{DaysPrune}, $in{aim}, '', '', $in{user_ratings}, #19

$mod_q, $in{private_message}, $in{private_message_notify}, 'yes', '', $new_title, #26

$birthdate, $ipaddy, $in{parent_email}, $pntf_hide, $poll_ban, $avatar_url, # 32

$avline, $tzline #38
$thismemarray[61] = $quickreply;
);

&WriteMemberProfile($next_number, @thismemarray);

# Update the memberslist indexes
# &UpdateOLIdexLine($next_number, join("|#|", map { $_ =~ s/|[#*]|//g; $_; } @thismemarray[5,6,9,16,17,18,19]));
# &UpdatePCdexLine($next_number, 0);
# &UpdatePermsdexLine($next_number, (($mod_q eq "Q" ? 1 : 0) . "|&|" . ($permission =~ m/COPPA/ ? 1 : 0)
# . "|&|" . ($mod_q eq "Q" ? 0 : 1) . "|&|Junior Member|&||&|$GotTime{HyphenDate}"));

# update associated files
my $total_members = scalar(@members) + 1; #the total number of registered users

I added a comma after $tzline and before the #38, now half the error is gone. My website is at

http://4.3.203.28/tin_benders/ and from there you can access the UBB and try to register. I'd really apprecaite the help, my club wants to go public with our site soon, and I fear it isn't ready.

TIA!

--Phillip

take

$thismemarray[61] = $quickreply;

and move it until after the

);

but before the

&WriteMemberProfile($next_number, @thismemarray);

To you, I owe my life. Thank you!!!!!

Wow, i missed a lot :x...

OK, I'm not sure if I'm the only one lost here, BUT:

1) Did we solve the problem of the user not being able to turn off the QR? I think that this is an important feature.

2) Were we able to get one of the radio buttons to show a response? Mine are still both blank.

3) If I have not choice but to disable this option in the user profile, how do I go about doing so?

Thanks,

- MT

1. No
2. No
3. If it eludes us, we have not a clue how to tell you to disable it...

Pretty much, with my messed up code for this version :choff:, you'll pretty much need to not even bother with the code for the profile code's since they dont work...

Since QR is stock code in 6.7 which should be released next month (beta this month, final is usually out a month or so after beta) this code is almost obsolete

...

Hmmm... OK.

quick reply is standard in 6.7... coming soon to a website near you

https://www.ubbdev.com/test/ubb/ultimatebb.php

Do we know when this is being released? This isn't going to be like the old days where they say it's going to be released and it takes months, is it?

- MT

the first public beta should be out any day now, and the final version depends on how many bugs are found

Just out of curiosity, how much time elapses between releases? Is it worth even modifying them if two months later there's a release?

- MT

The schedule has been sorta odd lately with all the work that went into 6.6, but we generally try to do a major release every few months.

I don't mean to undermine your creativity, BUT...

I fixed the problem... sort of. See, if the problem is that little crap about allowing people to have a decisiion in the matter, simply take it out. That's all I did and it worked beautifully. Granted, I've got some clean up to do, but I just tested it with perfect success...

Also, I think everyone is somewhat missing the point of the "Quck Reply." I mean, if you have basically the same options here as you have when you hit REPLY how is that any different?

What I'm doing now is getting rid of every option BUT the submit buttons. THAT is a quick reply....

Gizzy

One more old problem

Your site is blocked from our ISP

Can any one upload it for me, please

I just love ISP's that block security news sites... love love love lol...

Quote

Originally posted by Gizzy:

I just love ISP's that block security news sites... love love love lol...

LOL

Okay We love them too

but we want the hack plz

I don't have any other servers to upload them to...

*cough* flareupload *cough*

Oh

the upload file in ubbdev, isn't working?

https://www.ubbdev.com/ubb/upload/00017811/QuickReply6.6.txt

Thanks Gizzy, im working on it now

Wow it took an hour but i did it right... and it works. after messing up 2 other versions lol

Awesome.

I've installed it and it's working. Does anyone know how to add the graemlins to the window of the QR?

Is there also a way to make that spell check button actually say (SP) on it?

How does one go about making the qdown icon be theme settable for Colorforums like the edit/quote/report icons?

Replace

Code

				document.write('<a href="javascript:return false;" onclick="insertAtCaret(document.replier.message, unescape(\''+quote+'\')); document.replier.message.focus(); return false;"><img border="0" src="$vars_config{NonCGIURL}/qdown.gif" alt="Quick Reply w/quote" /></a> ');

with

Code

				document.write('<a href="javascript:return false;" onclick="insertAtCaret(document.replier.message, unescape(\''+quote+'\')); document.replier.message.focus(); return false;"><img border="0" src="$vars_config{NonCGIURL}'+style+'/qdown.gif" alt="Quick Reply w/quote" /></a> ');

Thanks as always Al.

Oh wait, you forgot something.

Add

Code

/graphics/

before

Code

'+style+'