TLD Bv2.1 Released - Threads Links Directory

slayer60: Got it, thanks. Will update the Links mod this week.

scroungr: Thanks, will look into the Florida thing when I have more time... I'm curious. Also, I noticed inktomi has done a small crawl on my site (less than 1 mb) but I haven't paid them anything. It's been back 48 times according to my stats. I wonder why it came to begin with? Oh well, can't know everything all of the time

scroungr actually I updated the main first link as well to keep things current just as Allen did a week or so back and just because I think Mark's copyright should be back on there.

I agree didn't mean to implie I didn't I always leave a copyright note if there is one

Nope did not take it as that

Just answering your question about whether I updated the first post as well

I may go through the couple remaining files for Mark and make sure this thing again is FULLY XHTML complaint as little changes here or there keeping blowing off the validation.

I'm very sorry - but I happen to be the culprit in removing the visible/display copyright notice from the code - although the copyright that appears at the begining of each script remained 100% intact and unchanged.

It was originally done just for display on my personal site and since none of my members have anything to do with programming/coding, nor could they ever afford ubbthreads software and would normaly opt for a freebie forums software if they felt like creating another specifically targeted resource such as what I currently run - i felt that having three lines of copyrite code display at the bottom of the page wouldnt be usefull to my members and may also look quite messy in presentation.

There was no intent in stealing your work - infact I saw your work as so great, that a few weeks after installing it and making so many display updates to it, I came to the conclusion that others would benefit from my small contributions/updates. So I re-uploaded it here, keeping all of your coded copyright notices intact and also including your original files into the archive.

All while doing that and finding that some of my additions to your code needed to be polished so they would work on everyone else's setup and their uniqueness (as mine was also quite unique), that I totally forgot to replace your visual copyright notices back into your scripts before redistributing them.

it was completely unintentional and i sincerely apologize for whatever frustration it may have caused you... that was not my intention - but i hope that this explanation of event sequences makes everything much more clear as how we got where we are now

Can you please verify the structure of this .zip file? There are several copies of each file in different trees, and it's kind of confusing.

Thanks!

One thing I noticed was with the latest code (I think it is, anyway), there is no ability to edit descriptions for Categories. I noticed this when I figured out that my w3t_links_categories table did not have a cat_desc field (probably missed when upgrading from an older version of this mod.). That, in turn, caused the Category display to indent the first line of sub-cats kind of strangely.

Long story shortened: I changed some of the code in links_show_cat.php to account for an empty description. So, around line 161, make this change:

Code

<br />    # Make sure we have something to print.<br />    if ($i <= $Numberofcats) {<br />                print "<br />                        <td valign=\"top\"><img src=\"{$config['phpurl']}/images/folder-c.gif\" alt=\"\" /> <font size=\"2\"><b><a href=\"links.php?op=List_Links&amp;cat_id={$cats['cat_id']}&amp;parent_id={$cats['parent_id']}&amp;title={$cats['title']}\"><u>{$cats['title']}</u></a></b></font><br />";<br />                if (empty($cats['cat_desc'])) {<br />                        //print "No Description.<br />";<br />                } else {<br />                        print "&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<font size=\"1\">{$cats['cat_desc']}</font><br />";<br />                }<br />

Is the ability to add/modify category descriptions supposed to be there? Or should I add it in myself?

Thanks for all your hard work!

Category descriptions were commented out by id242

You might want to view this thread first

https://www.ubbdev.com/forum/showflat.php/Cat/0/Number/101624

Okay, that makes more sense then. It was trying to print them out, but there was nothing there (though I did check the last version of the create_tables call and the column was there...). So for now, I will continue to edit the descriptions manually via mysql-front and work on an editing interface when time permits... if noone beats me to it. BTW, here's what it looks like right now, when you have descriptions to print show (and when there are none available): My Links Page

enjoy!

I actually spent some time on what you said today since Mark is back in action.

I added the capacity to add category descriptions and edit them in the links admin. Only changed file was links_admin.php

Before you could only add descriptions via phpmyadmin.

No offense taken, id242. It just caught me wrong at first. I appreciate you taking the time to provide some aesthetic improvements to the script, as mostly what I was doing when I first began the script was to get the inner workings of the code going. That's why it was released as a beta version anyway. Unfortunately I had to drop work on it for personal reasons.

I like Omegatrons idea of configuring the script to either display, or not, the notice. Someone suggested (forgive my memory, it's great but recall tends to be a problem

) possibly putting a link for a PayPal donate for those who wish to contribute. I may do that.

I do appreciate the kind words that people do like the script. That's rewarding in itself.

Anyway, I will be working on the script to further enhance it's usefulness to the community, so with that in mind here is a very short list of what I want to do first.

First and foremost will be the install script. It's pretty ugly due to the errors when you first install the script, so I'll be adding a check to see if there is a db installed yet or not. I think maybe a version check somehow is in order for upgrading from previous versions is in order.

Category descriptions should be the next to follow. It's apparent that Chuck (Omegatron) has already done something with this?

Paginating. Now the way it is written, if you have a zillion links they would all display on one page. So that needs to be addressed.

A configuration script for setting options needs to be written as well. I was thinking of using a db table for this to hold the variables. Any thoughts on this?

Of course, improvement on the admin script.

That's enough for now. Obviously, all input is requested. Thanks.

[]Omegatron said:
I actually spent some time on what you said today since Mark is back in action.

I added the capacity to add category descriptions and edit them in the links admin. Only changed file was links_admin.php

Before you could only add descriptions via phpmyadmin. [/]

Chuck, since you did this, did you update the first post? Actually, maybe you can provide just the links_admin as a .txt and I'll grab it.

The first post my friend was updated.

I think id242 added the description table but never made the ability to edit them via the script

For the record I have done the following on the script

1.XHTML corrections
2. Added ability to delete cats
3. Added ability to edit and add category descriptions
4. Added the copyright text in a configurable variable.

Only thing I really need is the subcats sorted for the drop down list when adding links, so my users can pick the correct spot to add the links. I have resorted to making mini alphabet prefixes to the subcats to get them below catagory names. Looks terrible and functions barely.
Thanks for all the hard work on this its a great addon.

Thanks Chuck, I'll be sure to add the probper credits.

[]Smilesforu said:
Only thing I really need is the subcats sorted for the drop down list when adding links, so my users can pick the correct spot to add the links. I have resorted to making mini alphabet prefixes to the subcats to get them below catagory names. Looks terrible and functions barely.
Thanks for all the hard work on this its a great addon. [/]

Could you clarify this for me? I think what you are saying is the drop down list should look something like:

Cat 1
Subcat 1
Subcat 2
Subcat 3
Cat 2
Subcat 1
Subcat 2
Subcat 3

etc.?

Chuck,

that worked beautifully! And the .zip looks much cleaner now, too!

Thanks for updating it all!

No problem that really is the work I have done on this mod is when someone wants something I went in and coded it

yes fishtails exactly But right now it sorts alphabetically with all cats and subcats included together

On the to do!

Hi,

Since you are updating your to do list

Not certain if you saw my post a while back:
----------------------------------------------
Hi,

This hack could be a nice way to make some additional ad revenue. What I was thinking about was to allow sites / companies that you link to to upgrade their link, for a fee or free (up to you I suppose).

This upgrading could be a different style to the link (i.e. larger font / bolder / italics) or even a small banner displayed next to or below the link.

It would be even better if we could add different levels of priority to the links (each with a different style associated to them) and then sort the list on links by priority first before alphabetically.

How much work would it be to add these features?

Sanuk!
----------------------------------------------

[]ksanuk said:
Hi,

Since you are updating your to do list

UBB Threads version 6.4
1st Time Installing this Integration
------------------------------------

Uploaded the files...then went to the links.php file through the net and clicked on Admin so that I could add the Categories. I got this:

--------------------
SQL ERROR: Unable to do_query: SELECT * FROM w3t_links_links WHERE approved = '0' ORDER BY 'date_added'
Table 'smoknz28_Infopop.w3t_links_links' doesn't exist
Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/smoknz28/public_html/ubbthreads/links_admin.php on line 74

SQL ERROR: Unable to do_query: CREATE TABLE w3t_links_categories ( cat_id int(11) NOT NULL auto_increment, parent_id int(11) default NULL, title varchar(50) NOT NULL default '', cat_desc varchar(60) default NULL '', cat_order tinyint(10) NOT NULL default '0', PRIMARY KEY (cat_id) )
You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ''', cat_order tinyint(10) NOT NULL defaDatabase tables have been created. You can now add categories and links.

---------------------

How many tables is this integration suppose to add to the database?

I'm getting errors after running this and just trying to verify a few things.

When I attempt to navigate around within this integration I get:

-----------------
SQL ERROR: Unable to do_query: SELECT * FROM w3t_links_categories WHERE parent_id = '0' ORDER BY 'cat_order'
Table 'smoknz28_Infopop.w3t_links_categories' doesn't exist
Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/smoknz28/public_html/ubbthreads/links_show_cat.php on line 66
There are currently 0 links in our database
------------------------------------

Ran into the same issue myself. First, drop the two tables it created in phpMyAdmin. Then look in links_admin.php and replace the create table w3t_links code, (found around line 488), with:

CREATE TABLE w3t_links_categories
(
cat_id int(11) NOT NULL AUTO_INCREMENT PRIMARY KEY,
parent_id int(11) DEFAULT NULL,
title varchar(50) NOT NULL DEFAULT '',
cat_desc varchar(60) DEFAULT NULL,
cat_order tinyint(10) NOT NULL DEFAULT '0'
)

Now run the install script again.

I think I read that fishtails is planning to update the install script when time permits.

Jason

Hi,

"What I was thinking in terms of this would be a google or ask.com style, where sponsored links would be at the top seperated with a hr or in a sidebar. This, of course is a little further down the to do list though, but definitely on the list."

That would work for me

Sanuk!

I like the other feature suggestions that have been made (adding a small banner for some sites, auto-populating which category a link should be in based on which one you're located in, etc...), but the one thing I haven't seen yet is a 'Report broken link' feature... not too difficult. Could probably even be a PM to the Administrator or something....? Does anyone else need this?

Dumb question from *greenie* here. Which file do I alter in order to change the default font for links listings? They currently display in 12pt/10pt arial; I'd like to make it verdana or tahoma.

Thx!

[]Sky YYZ said:
Dumb question from *greenie* here. Which file do I alter in order to change the default font for links listings? They currently display in 12pt/10pt arial; I'd like to make it verdana or tahoma.

Thx! [/]

links_show_links.php around line 180. Eventually all of the script will be based on the css.

[]Sky YYZ said:
Ran into the same issue myself. First, drop the two tables it created in phpMyAdmin. Then look in links_admin.php and replace the create table w3t_links code, (found around line 488), with:

CREATE TABLE w3t_links_categories
(
cat_id int(11) NOT NULL AUTO_INCREMENT PRIMARY KEY,
parent_id int(11) DEFAULT NULL,
title varchar(50) NOT NULL DEFAULT '',
cat_desc varchar(60) DEFAULT NULL,
cat_order tinyint(10) NOT NULL DEFAULT '0'
)

Now run the install script again.

I think I read that fishtails is planning to update the install script when time permits.

Jason [/]

Worked....thanks.

Matty good idea.. as my directory gets populated it will be needed.

Hi,

Found a small bug in the Top Rated links script. While the averages are calculated correctly, the links are ordered on total amount of points they have received.

This means that a link with 3 times a 1 star rating will appear before a link with once a 5 star rating.

Anyway, obviously not a major issue, but figured I'd point it out anyway.

Sanuk!

I am just starting a threads driven site and had a question about TLD. I have it installed and I can't seem to make a sub folder.

1. I go to the TLD panel
2. I click on ADMIN
3. I click on "Show Categories"
4. I enter a new category in the box where it says ""Add Sub Category"
5. The category gets added, but not as a sub categrory, it is a top level category.

What am I doing wrong?....

Line 201 of links.php looks like this

VALUES (0, '$title', '$description')

change to this:

VALUES ('$parent_id', '$title', '$description')

I installed this for him last night.

I just applied this fix for you.

The file was actually links_admin.php

Thanks.

Duh yeah I hate typos. Thats the file I meant.

Yeah, I knew what you meant, just thought I'd post in case anyone else wanted to make the fix to their copy.

Wow, four posts in an hour...

Thanks Josh! I didn't want to bother you with it... I just assumed it was operator error.

By the way, do you ever sleep. I went to bed at midnight and you installed Chat and Links after that. Thanks for the hustle!

Grant

LOL

I never sleep.

But I dream of someday being able to sleep.

The directions lost me here.

Add a link to your menu to go to http://www.qualityfishing.net/ubbthreads/links.php .

where do I add this link, to what menu?

Well you add it in your UBBTHREADS templates ubbt_registerednav.tmpl and ubbt_unregisterednav.com

Now I visited your links. You might want to run the create table for links. Or if you problem was the creation of that one table you can go a few posts up and get the updated command.

I forgot to add the comment that you are dealing with a dork so type slowly, and clearly . ; )

I don't see were to add it in my trnp files ubbt_registerednav.tmpl and ubbt_unregisterednav.temp I don't see anything in there for links, What should it look like?

Also, you say I should also run the create table for links. How do I do that?

Steelhead, Mmmm....hey, don't try taking any titles away from me!!

I'm the biggest numb-nutt when it comes to this php schtuff....

But with time and patience from the many others who've helped me....I'm slowly learning.

I'm not sure that you and Chuck are on the same sheet of music here and to be quite honest...you have lost me as well...but hey, it doesn't take much to lose me on this schtuff.

It almost sounds like you are trying to figure out how to add links to your database. However, if that is not the case...then what Chuck is refering to is that if you want to make life a bit easier on your members and would like to integrate a link to your top menu for them...then you would need to add the hyperlink so that they can click on it so it can bring them to the TLD.

If that is what you're trying to do...then go to:

ubbthreads/templates/default/

Open ubbt_registerednav.tmpl (this is the menu bar that your registered users will have available to them)

Edit this file adding the following code somewhere in between your other links:

·
<a href="http://www.qualityfishing.net/ubbthreads/links.php" target="_top">Links</a>

Next, you'll need to open and edit:

ubbt_unregisterednav.tmpl (this is the menu bar that your unregistered users will have available to them)

Edit this file adding the following code somewhere in between your other links:

·
<a href="http://www.qualityfishing.net/ubbthreads/links.php" target="_top">Links</a>

thanks

You're welcome...yea, looks like you are up and running.

Yeah he had the same problem alot of people had the category table did not get created for Links.

Chuck fixed me.
Thanks again Chuck

Dan

Fellow Threadaffficianados,

I am sitting here populating a new threads driven website. I am using the TLD mod. I am trying to add a URL that starts with "https://" instead of "http://" Apparently TLD automatically adds "http://" to the beginning of any string you add in the input form. "http://" is already in the box, but if I delete it out and enter the "https://blahblah blah.com" link it gets "http://" added to the beginning with ain't gonna work.

Is this a limitation of TLD or am I doing somethnig wrong. Is there a way to mod this mod to allow me to put in any URL I want... I am sure this feature was put in to cut down on non legit URLs but it is blocking a way to eneter "https://" which is legit...

Thanks for the great wotk FishTails!

Actually, I never even thought about https for secure connection! I'll consider this a bug, and will look into it further. Meanwhile, if you have a link with the https, you should be able to add it directly via phpmyadmin. When the links are called from the database, it does not check for https or http, etc. Only when a link is submitted is it checked for valid URL, and as I said, I never took this into consideration when I started TLD.

edit

Just a note, it's just a matter of changing the regexp on the submit_link.php script.

FishTail,

Yep, you don't see a lot of them (https://) but they are out there.

Maybe an update in the future that lets submitter pick between "http://" or "https://" or let them enter the entire URL and then check it again these two protocols and kick back an error message if they attempt to add a bad URL string.

I took a quick look at the file you referenced. I think I will wait and see if you add this tweek in a future update. I am not in a hurry. It would just be nice to be able to add these links.

Thanks again for making this cool mod!

Later...

This is what you need to change:

Code

<br />                 if (strstr($url, "http://") === false)<br />                        {$url = "http://".$url;}<br />

I just don't know how it would need to be altered.

I can't get .asp files to add.

I noticed it still isn't running correctly without register globals enabled. I made a few fixes that got it limping along, but haven't done an exhaustive search to make sure all the functionality is working. I wanted to post to find out if one of the maintainers was already doing it before I dug around anymore.

Lee

Post deleted by Pasqualist

This my first installation of this add-on. I installed it from the attachment on page 1, but when I bring up links.php, I get the following errors:

[]SQL ERROR: Sun, Feb 29 2004 14:01:06 +0100 Unable to do_query: SELECT lid,cat_id FROM w3t_links_links WHERE approved = '1'
Table 'pasqual_cznet.w3t_links_links' doesn't exist
Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /hsphere/local/home/pasqual/tsjechie.net/forum/links_show_cat.php on line 46
SQL ERROR: Sun, Feb 29 2004 14:01:06 +0100 Unable to do_query: SELECT * FROM w3t_links_categories WHERE parent_id = '0' ORDER BY 'cat_order'
Table 'pasqual_cznet.w3t_links_categories' doesn't exist
Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /hsphere/local/home/pasqual/tsjechie.net/forum/links_show_cat.php on line 66[/]

Ok, I understand.. no tables have been created so far, so I follow the admin link...

Another SQL error comes up:

[]SQL ERROR: Sun, Feb 29 2004 14:03:01 +0100 Unable to do_query: SELECT * FROM w3t_links_links WHERE approved = '0' ORDER BY 'date_added'
Table 'pasqual_cznet.w3t_links_links' doesn't exist
Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /hsphere/local/home/pasqual/tsjechie.net/forum/links_admin.php on line 74 [/]

Ok, since this is my first installation of this add-on, I click you can do so by clicking here.

The following 2 errors come up:

[]SQL ERROR: Sun, Feb 29 2004 14:05:08 +0100 Unable to do_query: SELECT * FROM w3t_links_links WHERE approved = '0' ORDER BY 'date_added'
Table 'pasqual_cznet.w3t_links_links' doesn't exist
Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /hsphere/local/home/pasqual/tsjechie.net/forum/links_admin.php on line 74 [/]

and

[]SQL ERROR: Sun, Feb 29 2004 14:05:08 +0100 Unable to do_query: CREATE TABLE w3t_links_categories ( cat_id int(11) NOT NULL auto_increment, parent_id int(11) default NULL, title varchar(50) NOT NULL default '', cat_desc varchar(60) default NULL '', cat_order tinyint(10) NOT NULL default '0', PRIMARY KEY (cat_id) )
You have an error in your SQL syntax near ''', cat_order tinyint(10) NOT NULL default '0', ' at line 8Database tables have been created. You can now add categories and links.

[/]

Not exactly a smooth installation!

Anything I miss here ?

Anyone who can help me solving this ?

got a link to your install?

Post deleted by Pasqualist

Your tables do not exist try these through phpmyadmin

CREATE TABLE `w3t_links_categories` (
`cat_id` int(11) NOT NULL auto_increment,
`parent_id` int(11) default NULL,
`title` varchar(50) NOT NULL default '',
`cat_order` tinyint(10) NOT NULL default '0',
`cat_desc` varchar(60) default NULL,
PRIMARY KEY (`cat_id`)
) TYPE=MyISAM AUTO_INCREMENT=0 ;

CREATE TABLE `w3t_links_favorites` (
`num` int(9) unsigned NOT NULL auto_increment,
`lid` int(9) unsigned NOT NULL default '0',
`uid` int(9) unsigned NOT NULL default '0',
PRIMARY KEY (`num`),
KEY `FAV_indx1` (`uid`)
) TYPE=MyISAM AUTO_INCREMENT=0 ;

CREATE TABLE `w3t_links_links` (
`lid` int(11) NOT NULL auto_increment,
`cat_id` int(11) default NULL,
`approved` tinyint(4) NOT NULL default '1',
`title` varchar(100) NOT NULL default '',
`url` varchar(100) NOT NULL default '',
`description` text NOT NULL,
`date_added` int(11) unsigned NOT NULL default '0',
`name` varchar(100) NOT NULL default '',
`email` varchar(100) NOT NULL default '',
`hits` int(11) NOT NULL default '0',
`user_number` int(11) NOT NULL default '0',
`member` char(2) NOT NULL default '',
`linkratingsummary` double(6,4) NOT NULL default '0.0000',
`totalvotes` int(11) NOT NULL default '0',
PRIMARY KEY (`lid`)
) TYPE=MyISAM AUTO_INCREMENT=0 ;

I dumped these from my working install

Thanks Chuck!

I created the tables and the links page loads fine now. But while testing the script, I encountered a problem:

It will not create subdirs! When I create a subdir, it just creates a main dir... very weird. Any idea ?

Maybe the file attached got reverted somehow. I know I had made some changes and included them on Marks direction and one of the things I did is include it. Maybe I will try and get a quick minute and zip up my php files for you to try.

email me at [][email protected][/] and I will send them to you.

subdir? Are you pertaining to categories and sub-categories? Basically, first you create the main cats, then to the right of each top level category in the admin there is another box to the right to create sub-directories.

Fellow Threadafficianados,

About 6 weeks ago I brought up the point that TLD will not allow a "https://" link to be added. There was some discussion and the only real advise to edit links_submit.php. Bottom line, I am not all that sharp with php and would love more specific help.

So how can I get TLD to either allow "httpXXXXX" or allow anything and let the URL confirmation part catch the bad URLs.

I think I need to do something with these lines...

// Let's make sure the url format is correct
if (strstr($url, "http://") === false)
{$url = "http://".$url;}
// Is the url valid and can we read it
if (@fopen($url, "r"))

...but I have been monkeying around with this for a couple of hours to no avail.

Help!...Pweese

Well I don't know this mod not using it but I may take a look later but based off your code have you tried

// Let's make sure the url format is correct
if (strstr($url, "https://") === false)
{$url = "https://".$url;}
// Is the url valid and can we read it
if (@fopen($url, "r"))

to see if it at least passes the https:// addresses? if not there may be something else in the code stopping it.

I tried that change and it still kicks out an error message. There must be more coding that checks the URL. There are about 5 php files with this mod.

I think the problem lies within the fact that https is for secure connections, and the script is trying to open the file for reading only. I'll look into this more and see if I can come up with a more definitive answer. I've been working on some other parts of the script and forgot.

Thanks in advance for the help!

The mod works great in all other ways

PS I think you are right about part of the problem is not being able to open a https:// link for validtion. I was adding another link to TLD that is a standard http:// link. It kept coming up as a bad URL. I could visit the URL manually with no problem. I then noticed that the http:// page was redirecting to a https:// page. So it is a two headed issue. One is allowing https URLs to be entered into the system and the other is validating the https URLs.

Later..

(man this is a long thread)

There is a site similar to mine, that has A LOT of 1st place/top 10 rankings for nearly all the terms of it's links db's subcategories. All the indexed and ranked links are from the links section.

My question is, is there a way to make TLD spider friendly?

If the answer is yes, there are $ signs involved. (as in, I'd pay someone to hook me up with it) Thanks.

Spider friendly is definitely on the list, but considering where I am in the script it may be a while for that.

With google's recent changes, this might be a significant help in search engines, specifically google - would be great if short, search-engine friendly url's are coming

Post deleted by foppen

When I call the links.php I get an error, is says its not in the right directory :
Warning: open_basedir restriction in effect. File is in wrong directory in /usr/local/psa/home/vhosts/videomontageforum.nl/httpdocs/ubbthreads/links.php on line 53

I checked but it is there!

What am I doing wrong??????
Using Threads 6.3

B.t.w My webhoster is using one of the latest PHP versions however I don't know excactly wich version it is...

To find out what version of php you're running, use a text editor and put the following lines in it:

Code

<br /><?<br />phpinfo();<br />?><br />

Save it as a .php file, upload it to your site and then browse to the file. It will tell you everything about your php setup.

Hi Fishtails,
I did that and ist says version:
PHP Version 4.2.2 and a lot of other data came up.
Is there any chance that TLD will run on my server?

I tried several setup's, I loaded up the files in the right directories, I get the admin menu but as soon as I click the 'links home' it gives an error.

I also can not make a new categorie it says: you did not enter anything, try again!

There must be something wrong here!!!! but what??????
Otherwise I asked someone from this group to install it for me?

I came a bit further!!!!
When I try to add a categorie it says: you did not enter anything, try again?

I just went to your site and checked the links page. It seems to be running fine, but of course that's not logged in and I can't see your admin panel. I have to leave town today and won't be back until Monday, so I won't be able to look further into this until I get back. I'm wondering thoug, which script you downloaded, as there were some changes done.

Thanks for youre reply,
I think I used the latest script where the logfile says:
01/04/2004 - 1.6 released
- Just a compilation of all files/fixes and features added

Well,I wait for youre return,
Have a good trip

Who can help me to install this TLD.
I have tried several setups but I can't get it to work.
Any help is highly appreciated!!!!!!!!!!!

the TLD as it is written in the latest version does not support Register Globals being off. You may want to check and see if that setting is set up that way in your php.ini if so then you will need to either turn it on (security risk) or set the variables manually in the script via Http_Post_Vars or some other method. I have not completed this yet on my site or I would upload an attachment for you.

Finally...This is the reason that it is not working for me.
Today I contacted my webhoster and they told me that 3 weeks ago they switched off Register Globals for security reasons just as you told me!

They also linked my to PHP information site but I could not find any help there. I have to make some minor changes in the TLD php code but I do not know enough about php to do that by myself.
So, if you have it fixed please send me a copy of the solution.
regards,
Foppen

Can it be that TLD V1.5 dosn't work with Threads V6.4.2 ? I use it for a while up to V6.4.1 without any problems and now after update to 6.4.2 The Links lib dosnt show any links and as Admin I m no longer able to post new links. I get an error about an illegal email adress if I try to add a link.

/edit: ok, register globals is my problem. server changed it.

/edit 2: fixed with .htaccess for the dir. If you run Apache put a .htaccess with this content in your dir where the script is: php_flag register_globals on

I have updated the script so that it works on my site with register globals turned off. I dont think I made a lot of significant changes in functionality so here is the file if you want to test it on your own site.

Attached File

112587-links.zip (283 downloads)

Thanks Pappy

Works OK now, Thanks verymuch for youre help!!!

Your Welcome Allen & Foppen

When I enter a description for a subcategory, the description doesn't show. Why could that be ? It does work for the main categories.
When pressing the edit button of the subcategory, the description is still there...

PLEASE help

I don't think this has been posted - but I had a client want me to modify the category list when you added a link. All the categories and subcats were jumbled together. I modified things to sort by main category, then subcategory.

Here's how.

In links_submit_form.php

Find this:

Code

<br />     $query = "SELECT * FROM {$config['tbprefix']}links_categories ORDER BY title";<br /><br />     $links_cat = $dbh -> do_query($query);<br /><br />     $total_cats = mysql_num_rows($links_cat);<br />

Change to this:

Code

<br />$query = "SELECT * FROM {$config['tbprefix']}links_categories WHERE parent_id = 0 ORDER BY title";<br />$main_cat = $dbh -> do_query($query);<br />$total_main_cats = mysql_num_rows($main_cat);<br />$cat_pulldown = "<select size=\"1\" name=\"cat_id\"> \n <option selected value=\"$cat_id\">$title</option> \n";<br />for ($y= 0; $y < $total_main_cats; $y++) {<br />	$cat_row = mysql_fetch_assoc($main_cat);<br />	$cat_pulldown .= "<option value=\"{$cat_row['cat_id']}\">&bull;{$cat_row['title']}</option> \n";<br />     $query = "SELECT * FROM {$config['tbprefix']}links_categories WHERE parent_id = '{$cat_row['cat_id']}' ORDER BY title";<br />     $links_cat = $dbh -> do_query($query);<br />     $total_cats = mysql_num_rows($links_cat);<br />	for ($x= 0; $x < $total_cats; $x++) { <br />	    $row = mysql_fetch_assoc($links_cat);<br />		$cat_pulldown .= "<option value=\"$row[cat_id]\">&nbsp;-{$row['title']}</option>\n";<br />	<br />	}<br />	<br />}<br />$cat_pulldown .= "</select>";<br />

Then in links_submit_form.tmpl

Find this:

Code

<br /><select size="1" name="cat_id"><br /><option selected="selected" value="$cat_id">$title</option><br /><br />UBBTPRINT;<br />print "\n";<br />for ($x= 0; $x < $total_cats; $x++) { //UBBTREMARK<br />     $row = mysql_fetch_assoc($links_cat);<br />     print "<option value=\"$row[cat_id]\">$row[title]</option>\n";<br />     }<br />UBBTPRINT;<br />echo <<<UBBTPRINT<br />

Change to this:

Code

<br />$cat_pulldown<br />

Seems to work fine at www.steelheader.net

Thanks for the quick reply Josh!

Unfortunately this does not solve my problem... showing descriptions from subcategories

Ah - actually I didn't know the answer to your question - I just used quick reply to post my code mod.

SEO Friendly URLs would sure be nice....

If anyone can make this happen....$$$$

I did it for you.

Wasn't easy - had to edit pretty much every link thoughout the whole thing.

Any place current code (with bugfixes, etc) can be found?

Further back in the list I redid it and posted my changes in an attachment. My updates were to make it work with register globals off... There is still some bugs with the way it uses category descriptions which I do not use so I did not look deep into them...

ok, thank you

OK- to make this work with 6.5.

In links_admin.php and links_redirect.php change this:

require ("main.inc.php");

To this:

require ("./includes/main.inc.php");

And in links.php you need to change this:

require ("main.inc.php");
require ("links/languages/${$config['cookieprefix']."w3t_language"}/links.php");

To this:

require ("./includes/main.inc.php");
require ("languages/{$myprefs['language']}/links.php");

thanks for the fixes

Anyone have problems getting sub categories to work? I enter em, but they show as main cats.

[]http://www.leetgamers.org/images/graemlins/kid_rofl.gif[/]

edit.
I swear I thought he was talking about subforums in threads.DOH!

Got it fixed. Thanks MattyJ!

Not a problem... glad that cleared it up!

what? something you might wanna share?

Allen,

actually, I just sent him copies of my files...

I'm pretty sure there was some fix I did a while ago to the links_show_cat.php file that enabled the sub-cats showing on the main index.... but it was so long ago, it was easier for me just to send JC my files.

You can see what mine looks like at http://www.mattreinfeldt.com/

hth.

I see

I just installed Links v1.5 to my UBB.Threads v6.4, and I am having the same problem that Pasqualist had. What I don't understand is, what do you mean by "Your tables do not exist try these through phpmyadmin"? How or where do I find this phpmyadmin?

[]Omegatron said:
Your tables do not exist try these through phpmyadmin

CREATE TABLE `w3t_links_categories` (
`cat_id` int(11) NOT NULL auto_increment,
`parent_id` int(11) default NULL,
`title` varchar(50) NOT NULL default '',
`cat_order` tinyint(10) NOT NULL default '0',
`cat_desc` varchar(60) default NULL,
PRIMARY KEY (`cat_id`)
) TYPE=MyISAM AUTO_INCREMENT=0 ;

CREATE TABLE `w3t_links_favorites` (
`num` int(9) unsigned NOT NULL auto_increment,
`lid` int(9) unsigned NOT NULL default '0',
`uid` int(9) unsigned NOT NULL default '0',
PRIMARY KEY (`num`),
KEY `FAV_indx1` (`uid`)
) TYPE=MyISAM AUTO_INCREMENT=0 ;

CREATE TABLE `w3t_links_links` (
`lid` int(11) NOT NULL auto_increment,
`cat_id` int(11) default NULL,
`approved` tinyint(4) NOT NULL default '1',
`title` varchar(100) NOT NULL default '',
`url` varchar(100) NOT NULL default '',
`description` text NOT NULL,
`date_added` int(11) unsigned NOT NULL default '0',
`name` varchar(100) NOT NULL default '',
`email` varchar(100) NOT NULL default '',
`hits` int(11) NOT NULL default '0',
`user_number` int(11) NOT NULL default '0',
`member` char(2) NOT NULL default '',
`linkratingsummary` double(6,4) NOT NULL default '0.0000',
`totalvotes` int(11) NOT NULL default '0',
PRIMARY KEY (`lid`)
) TYPE=MyISAM AUTO_INCREMENT=0 ;

I dumped these from my working install [/]

Bob,

there are different ways of accessing your MySQL tables, it just depends on your host and how it's all set up. On all the sites I run, I am able to access phpmyadmin from the cpanel. If you can't find it there, you can download it from http://www.phpmyadmin.net/home_page/ and follow the installation instructions. Make sure to put some security controls on the directory you install it to, though (.htaccess file). Or you can go download MySQL-Front 2.5 from http://www.bumpersoft.com/Programming/Databases_and_Networks/Review_982_index.htm (you have to allow remote access to the database to get this to work...). Either one will work for you. There are other options as well, I'm sure. Those are just the two most convenient ones for me.

Thank You MattyJ!

Isn't the lastest and greatest release of this mod supposed be included in the first post. I thought that was the protocol. I am having the same issue where adding sub categories become catagories. Does anyone have the fix?

no reason us admins shouldn't see this as well...

so, in links_admin.php, change the edit_link function to be the following:

Code

<br />function edit_link() {<br />    GLOBAL $lid,$dbh,$config;<br />                <br />    $query = "<br />       SELECT *<br />       FROM {$config['tbprefix']}links_links<br />       WHERE lid = '$lid'<br />    ";<br />    $result = $dbh -> do_query($query);<br />    $row = mysql_fetch_assoc($result);<br />    $tCatId = $row['cat_id'];<br />    $query = "<br />	SELECT title<br />	FROM {$config['tbprefix']}links_categories<br />	WHERE cat_id = '{$tCatId}'<br />    ";<br />    $mth = $dbh -> do_query($query);<br />    list($tTitle) = $dbh -> fetch_array($mth); <br />    $dbh -> finish_sth($mth);<br />    $query = "SELECT * FROM {$config['tbprefix']}links_categories WHERE parent_id = 0 ORDER BY title";<br />    $main_cat = $dbh -> do_query($query);<br />    $total_main_cats = mysql_num_rows($main_cat);<br />    $cat_pulldown = "<select size=\"1\" name=\"cat_id\"> \n <option selected value=\"{$tCatId}\">{$tTitle}</option> \n";<br />    for ($y= 0; $y < $total_main_cats; $y++) {<br />	$cat_row = mysql_fetch_assoc($main_cat);<br />	$cat_pulldown .= "<option value=\"{$cat_row['cat_id']}\">&bull;{$cat_row['title']}</option> \n";<br />	$query = "SELECT * FROM {$config['tbprefix']}links_categories WHERE parent_id = '{$cat_row['cat_id']}' ORDER BY title";<br />	$links_cat = $dbh -> do_query($query);<br />	$total_cats = mysql_num_rows($links_cat);<br />	for ($x= 0; $x < $total_cats; $x++) {<br />		$results = mysql_fetch_assoc($links_cat);<br />		$cat_pulldown .= "<option value=\"$results[cat_id]\">&nbsp;-{$results['title']}</option>\n";<br />	}<br />    }<br />    $cat_pulldown .= "</select>";<br /><br />    print "<br />        <form action=\"links_admin.php?op=process_edit_link\" method=\"POST\"><br />        <input type=\"hidden\" name=\"lid\" value=\"$lid\"><br />        <table border=\"0\" cellpadding=\"2\" cellspacing=\"2\"><br />        <tr><td align=\"right\"><b>Select Category:</b></td><br />        <td><br />	$cat_pulldown<br />    ";<br />    print "<br />        </td><br />        </tr><br />        <tr><td align=\"right\"><b>URL:</b></td><td><input name=\"url\" size=\"40\" value=\"$row[url]\" /><br />        </td></tr><br />        <tr><td align=\"right\"><b>Title:</b></td><td><input name=\"title\" size=\"40\" value=\"$row[title]\" /><br />        </td></tr><br />        <tr><td align=\"right\"><b>Description:</b></td><td><textarea name=\"description\" rows=\"3\" cols=\"40\">$row[description]<br />        </textarea></td></tr><br />        <tr><td align=\"right\"><b>Submitted By:</b></td><td>$row[name]<br />        </td></tr><br />        <tr><td align=\"right\"><b>Email:</b></td><td>$row[email]<br />        </td></tr><br />        <tr><td></td><td><input type=\"submit\" name=\"edit_link\" value=\"Edit Resource\" /><br />        </td></tr><br />        </table><br />        </form>";<br />}<br />

I think the selected item code could be a little cleaner, but it seems to be working for me...

Enjoy!

[]ekempter said:
Isn't the lastest and greatest release of this mod supposed be included in the first post. I thought that was the protocol. I am having the same issue where adding sub categories become catagories. Does anyone have the fix? [/]

I fixed this in links_admin.php in function add_sub_cat.

Change:
$query = "INSERT INTO {$config['tbprefix']}links_categories
(parent_id, title, cat_desc)
VALUES (0, '$title', '$description')
";

To:
$query = "INSERT INTO {$config['tbprefix']}links_categories
(parent_id, title, cat_desc)
VALUES ('$parent_id', '$title', '$description')
";

I also found that if you had sub categories but no category description the first sub category was needlessly indented. To resolve this, I added a to links_show_cat.php

Change:
# Make sure we have something to print.
if ($i <= $Numberofcats) {
print "
<td valign="top"><img src="{$config['phpurl']}/images/folder-c.gif" alt="" /> <a href="links.php?op=List_Links&cat_id={$cats['cat_id']}&parent_id={$cats['parent_id']}&title={$cats['title']}">{$cats['title']}</a> {$cats['cat_desc']}
";

To:
# Make sure we have something to print.
if ($i <= $Numberofcats) {
print "
<td valign="top"><img src="{$config['phpurl']}/images/folder-c.gif" alt="" /> <a href="links.php?op=List_Links&cat_id={$cats['cat_id']}&parent_id={$cats['parent_id']}&title={$cats['title']}">{$cats['title']}</a> {$cats['cat_desc']} 
";

The email that is sent needs to be changed to use the From e-mail addresss specified within the config settings 'contact email address' field. I didn''t have time to fix this one.

I'm sure that others would appreciate it if the first fix was included in the release.

HTH.

Anyone have this problem, links waiting for approval, are approved, but do not show....???

did you check the cat_id of the ones you approved?

links_show_cat.php script does not count the links within main categories. The attached script revises this in v 1.5.

Attached File

116862-links_show_cat.zip (42 downloads)

hey guys, i get this problem after i've installed it.

Warning: main(main.inc.php): failed to open stream: No such file or directory in /home/fordmond/public_html/ubbthreads/links.php on line 52

Fatal error: main(): Failed opening required 'main.inc.php' (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/fordmond/public_html/ubbthreads/links.php on line 52

yep, i have searched these forums, but all i get are sql errors from threadsdev when submitting it, weird.

Okay got the last prob fixed. Any ideas how to get WOL to show the links sections properly?

*bump*

What is WOL?

it's short for, "Who's Online".

hehe ok thanks

I guess its time for a new thread for this add on with an actual file attached to it.

Post deleted by ekempter

you can edit the link as Admin by clicking on the green LED button. The red one will delete the link.

* Arrgh tables!

It looks like you are trying to create tables which already exit.
Have you already used this mod? If so you don't need to create the tables, they should already be there.

[]http://www.calpernia.com/ubbthreads/images/icons/grnlite.gif[/]
* Hi all. Love the idea of this mod, I modded a very simple guestbook script to do something similar in a much less cool way, looking forward to replacing it with this. After several tense hours of struggling to install the five different versions of this script linked in this thread and guess which fixes applied to which version, I got something up and running, but upon trying to add a link I get this message:
[] -- Your email address does not appear to be valid. Please check the format and try again[/]
* I don't need it to validate email anyway since it's using the email on record for the user, but I suspect the issue is the globals thing that made it impossible to even submit a category until I added that get_input reference to the header. Is there a similar ref I can put into the links_submit to keep these variables from blanking out?
* As someone suggested, it would be a good idea to remove the non-working attachments here, at least. This is such a good mod it seems that lots of people want to try and use it.

The links_submit_link script doesn't like caps in email addresses. Like you said, there isn't a reason for it to be validating the email address anyway so I took mine out.

Under: // Check to see if the form was filled out completely
Comment out (//) the following -
From: if (!valid_email($email))
To: } (right after exit which is approx 4 lines down).

Ok so admittedly I am probably getting carried away with this script but I can't seem to leave it alone. The attachment contain the following mods:

1. Fixed the default rate in the 'rate this link' page to default to 1. It currently defaults to blank. I think the author intended it this way but made a typo.
2. Added a configurable option to allow / disallow the link submitter from voting on his/her own link.
3. Added a configurable option to specify the minimum number of votes required before a link will appear on the Top Rated page and before the 'stars' ratings will appear next to a link.
4. When a link submitter clicks on his/her link, it is no longer counted as a hit.

I'm going to try to leave this alone now but I'm not crazy about the way that the redirect sends the link in the clear.

Attached File

118140-TLD.zip (243 downloads)

So, does the first post in the thread contain the very latest release?

I tried to install this mod when it was still "new" and had errors everywhere. lol.

But since everyone is getting it working and you devoted some time to it, I might have to give it a go again...

[]DrChaos said:
So, does the first post in the thread contain the very latest release?

I tried to install this mod when it was still "new" and had errors everywhere. lol.

But since everyone is getting it working and you devoted some time to it, I might have to give it a go again... [/]

ditto!

I think the first post is the latest (it's what I started with). Did it error out before or after you added my mods? You may need to include the other mods that I included in this thread. What kind of errors are you getting? Seems like this thread should me in the mods forum.

I was just wondering if there was one zipped file that had all the fixes. I installed it a long time ago. But as I read the post it seems that few people got it to work with your help.

I'll try and zip up what I have tonight.

I've got this far now guys
i've installed it, called up links.php and now get this error

[]
Script:
Line#:
SQL Error: Table 'fordmond_threadsdb.w3t_links_favorites' doesn't exist
SQL Error #: 1146
Query: SELECT w3t_links_favorites.uid, w3t_links_favorites.lid, w3t_links_links.lid, w3t_links_links.title, w3t_links_links.url, w3t_links_links.description FROM w3t_links_favorites, w3t_links_links WHERE w3t_links_favorites.uid = '2' AND w3t_links_favorites.lid = w3t_links_links.lid
[/]

any ideas?
i know it's something to do with tables, but i dont know how to fix it!

You're missing tables. I don't know if there is an install script with this, but if there is, it appears that it didn't finish.

hmm dang diggity.
i suppose i could add them manually via phpmyadmin yeah?

Here are my files. Sorry for the delay.

Attached File

118876-links.zip (283 downloads)

i cant figure this out
why doesnt the install script create the tables guys?

Very appreciated

Looks pretty here:

https://www.ubbdev.com/forum/links.php

I updated the original post in this thread with emkempter's files added

[]AllenAyres said:
Very appreciated

Looks pretty here:

https://www.ubbdev.com/forum/links.php

I updated the original post in this thread with emkempter's files added

[/]

hey allen
yours doesnt seem to be working m8.

[] Warning: main(languages//links.php): failed to open stream: No such file or directory in /home/threadsdev/domains/ubbdev.com/public_html/forum/links.php on line 55 [/]

Im trapped at the same error. I use the latest version witch runs on php5 (globals off) under 6.4.x

after Update to 6.5 I modify this:

// Require the library
require ("includes/main.inc.php");
require ("languages/${$config['cookieprefix']."w3t_language"}links.php");

to reflect the moving of the main.inc.php to the includes directory but get:

Warning: main(languages/links.php) [function.main]: failed to open stream: No such file or directory in /...path.../dragonclan-forum.de/ubbthreads/links.php on line 41

Any Idea ?

[]Zarzal said:
Im trapped at the same error. I use the latest version witch runs on php5 (globals off) under 6.4.x

after Update to 6.5 I modify this:

// Require the library
require ("includes/main.inc.php");
require ("languages/${$config['cookieprefix']."w3t_language"}links.php");

to reflect the moving of the main.inc.php to the includes directory but get:

Warning: main(languages/links.php) [function.main]: failed to open stream: No such file or directory in /...path.../dragonclan-forum.de/ubbthreads/links.php on line 41

Any Idea ? [/]
I had the same problem, but I got it working but using the full paths.

Change this:

Code

<br />// Require the library<br />require ("includes/main.inc.php");<br />require ("languages/${$config['cookieprefix']."w3t_language"}links.php");<br />

To This:

Code

<br />// Require the library<br />require ("/path/to/ubbthreads/includes/main.inc.php");<br />require ("/path/to/ubbthreads/links/languages/english/links.php");<br />

Probably not the right way to do it, but it does work.

One important update on ANYTHING that you're converting to work on 6.5 - is that you have to change

${$config['cookieprefix']."w3t_language"}

to

{$myprefs['language']}

That'll fix why it's leaving "english" out of the language file include.

Thanks Josh. Last night I do the fix with fixed path to test out where the error comes from. I know that something was changed and that is it.

To bring TLD to work on Threads 6.5 do the following changens:

links.php:
require ("./includes/main.inc.php");
require ("./languages/{$myprefs['language']}/links.php");

links_admin.php
require ("./includes/main.inc.php");

links_redirect.php
require ("./includes/main.inc.php");

i'm still getting this problem:

Script:
Line#:
SQL Error: Table 'fordmond_threadsdb.w3t_links_links' doesn't exist
SQL Error #: 1146
Query: SELECT lid,cat_id FROM w3t_links_links WHERE approved = '1'

Please use your back button to return to the previous page.

how do i insert these tables?

Hmmm, even if i try the links_admin.php?op=upgrade_from_1_0 or the links_admin.php?op=create_tables manually which i've found in the links_admin.php file i STILL get the same error.
HELP!
I really want this working and it's doing my head in.

OK- I've put this on a couple of 6.5 forums. I don't have a "pretty" way to do it, or else I'd re-post the mod for 6.5.
If I find myself with free time, I will. But for now I'm swamed.

To use this mod with 6.5 - I did the following.

inks.php:
require ("./includes/main.inc.php");
require ("./languages/{$myprefs['language']}/links.php");

links_admin.php
require ("./includes/main.inc.php");

links_redirect.php
require ("./includes/main.inc.php");

Then I manually created the tables using my Threads SQL interface. The following 3 queries need to be run.

CREATE TABLE `w3t_links_categories` (
`cat_id` int(11) NOT NULL auto_increment,
`parent_id` int(11) default NULL,
`title` varchar(50) NOT NULL default '',
`cat_order` tinyint(10) NOT NULL default '0',
`cat_desc` varchar(60) default NULL,
PRIMARY KEY (`cat_id`)
) TYPE=MyISAM AUTO_INCREMENT=32 ;

CREATE TABLE `w3t_links_favorites` (
`num` int(9) unsigned NOT NULL auto_increment,
`lid` int(9) unsigned NOT NULL default '0',
`uid` int(9) unsigned NOT NULL default '0',
PRIMARY KEY (`num`),
KEY `FAV_indx1` (`uid`)
) TYPE=MyISAM AUTO_INCREMENT=11 ;

CREATE TABLE `w3t_links_links` (
`lid` int(11) NOT NULL auto_increment,
`cat_id` int(11) default NULL,
`approved` tinyint(4) NOT NULL default '1',
`title` varchar(100) NOT NULL default '',
`url` varchar(100) NOT NULL default '',
`description` text NOT NULL,
`date_added` int(11) unsigned NOT NULL default '0',
`name` varchar(100) NOT NULL default '',
`email` varchar(100) NOT NULL default '',
`hits` int(11) NOT NULL default '0',
`user_number` int(11) NOT NULL default '0',
`member` char(2) NOT NULL default '',
`linkratingsummary` double(6,4) NOT NULL default '0.0000',
`totalvotes` int(11) NOT NULL default '0',
PRIMARY KEY (`lid`)
) TYPE=MyISAM AUTO_INCREMENT=65 ;

Once you make those tweaks, and create the tables, then it should all function normally.

Probably wouldn't be difficult to figure out how to allow the admin script by the SQL error on initial install. Or create a "createlinktable.php" script which you could run first and then delete it. But the above works just fine.

Josh, your a star!
I tried copying the sql code from the file myself and enter it in the threads sql box, i guess i must have copied it slightly wrong as i got errors!
But now it's working like a treat!
thanks m8!

As I see there is a V1.8 avaible at the start posting. I take a look and its not compatible with threads 6.5 too. It use the old way for languages.

I try to change this and test out the version but I get strange results in my library. Must the DB changed if I do an Update from 1.5 to 1.8 ? Is the 1.8 compatible with php5 register global off?

hmmm... updated original post with latest bugfixes to use threads 6.5. It should run fine

hi. i have a prob. when my users submit a site, the 'date submited' shows up the same all the time.... like 01/01/70 or something like that.. i guess its something to do with the date_added in my database field. should it be null for default? what else must i make sure its adjusted? thenks

Thank you for the update, but I have still problems. I use a old 1.5 version for a long time. Some month ago someone post a version wich works with globals=off in this thread.

This version works fine for me. No problem with php5 and no big problem with ubb 6.5

After installing this 1.8.1 the links index page looks fine ( http://www.dragonclan-forum.de/ubbthreads/links.php ) but if yo try enter a section or edit a link the chaos begins.

Is a database modification needet to bring this to work again ?

/edit: I try to submit a link or create a category. Everytime I get an error that nothing is submited. I fear this version is not compatible with php globals=off

I have to put my backup in again.

Can anyone verify this ?

/edit: First bug found? In links_show_cat.php there is a $parent_id = "= $id";

in my version this is only: $parent_id = $id;

here is my version of links1.5
I do a compare between my version and 1.8.1. I use Beyond Compare and clean out all minor changes. The leftover differences are major changes between the versions. The followings files contains differences:

links.php
links_admin.php
links_rate_link.php
links_redirect.php
links_show_cat.php
links_show_links.php
links_submit_form.php
links_submit_link.php
links_submitrate_link.php
links_toprated_links.php
template/default/links_footer.php (just the copyright notice)

there are some differences in the code belongs to ' and ". I m not sure if these are the same in php so I leave it unchanged. In some places my code dont have ' ' around a value and the new one have " ". You will see it if compre it.

This pack works fine for me. Maybe this helps to find out why the new version doesnt work.

Attached File

121368-links15.zip (259 downloads)

[]Zarzal said:
/edit: First bug found? In links_show_cat.php there is a $parent_id = "= $id";

in my version this is only: $parent_id = $id;
[/]

That does look odd, there's also:

$parent_id = "= $parent_id";

and in links_show_links.php line #124 there's:
$parent_id = "= $id";

hmmm... I'll ask

Yeah, that definately seems incorrect.

Should at least be:

$parent_id = "$parent_id";

And

$parent_id = "$id";

grazi josh

Files updated here with the 3 bugfixes

this looks better. Links 1.8.1 begins to work on my site. The main index is ok and subcats too. You can browse links without problems. But there are still 3 problems:

1) The redirector doesnt work. If you click a link I get a blank page, on top of the page a horizontal line, below that line a 'generated by Opera', thats all. Nothing happen.

[update] It seems that is related to Opera. Some Kind of protection. It work with IE.

2) You cant edit any link. If you click the green led-button to edit a link you get the edit mask but without any data. The fields are still empty.

3) If you try to submit a link you fill out the form and send it. You get an answer that 'http:// (nothing more)' isnt correct. It seems that the input from the form is not submitted to the script.

I put back may backup in again....

I can do all those tasks here... hmmm - it would have to be a difference in how servers are setup.

1.5 does all those for you?

yes, 1.5 works real fine. Little bit above I attach my files. The thing with the redirector is Opera related, my fault. But the empty Input mask must be something different. I run on ZEUS, not on Apache with php5.x

As I notice in my 1.5 there are some additional varibales in some places. If you compare you see it. I do some testings but cant find out where is the problem with the input.

I cant edit
I cant send new one

That's a little over my head. I'll look at it, but I'm not sure if I can fix it. If someone else wants to take a look first, be my guest.

Files updated with minor xhtml-bugfixes

I get this error when try to add a category.

SQL ERROR: Fri, Jan 07 2005 10:29:22 +0100 Unable to do_query: INSERT INTO w3t_links_categories (parent_id, title, cat_desc) VALUES (0, 'Resa', '')
Resa was added to the database.

It worked before I switched webhotell.

Thanks
/Stefan

Just a heads up (might be in the previous 18 pages), I had to add a bunch of $tbclose's after the error messages to format the pages properly.

I combined mine with thumbshots.com to get a nice layout:

ViperAlley Resource Directory

I put a two-tiered display into place - nonmembers see the "free" thumbnail service which provides thumbnails for those sites listed in the DMOZ. My paying members see the paid service provided which provides for thumbnails of every site listed in the index.

Looks nice

I would like to make my admins control of this, so my moderators have to have links approved and turn off the delete feature for them.

Can someone tell me how to do this please?

Hey Photopost, any chance you could share how to integrate the thumbshots into TLD?

I can look at this for you if you like, it's probably easy, tho I'm not sure... been a while since I looked at the code.

[]AllenAyres said:
I can look at this for you if you like, it's probably easy, tho I'm not sure... been a while since I looked at the code. [/]

Thanks Allen

Untested:

OPEN links_admin.php

FIND:

Code

<br />// -----------------------------<br />// Make sure they should be here<br />   if (($user['U_Status'] != 'Administrator') && ($user['U_Status'] != 'Moderator')) {<br />      $html -> not_right ("You must be logged in, and be a valid administrator to access this.",$Cat);<br />   }<br />

REPLACE WITH:

Code

<br />// -----------------------------<br />// Make sure they should be here<br />   if (($user['U_Status'] != 'Administrator')) {<br />      $html -> not_right ("You must be logged in, and be a valid administrator to access this.",$Cat);<br />   }<br />

Thanks Allen, I will try that when I get home and let you know

Bit late of me

This works fine, thanks Allen

glad it worked for you

I'm not getting a setup screen which I think I should be?

Instead I get

Script:
Line#:
SQL Error: select command denied to user: 'bm3wadmin@localhost' for table 'w3t_links_links'
SQL Error #: 1142
Query: SELECT lid,cat_id FROM w3t_links_links WHERE approved = '1'

Please use your back button to return to the previous page.

Ok ive created the tables manually and its working now, although not sure why i didnt get the admin menu asking me to install and create all these?

Ah, another problem.. when submitted a new link I get

Warning: mail(): SMTP server response: 501 5.5.4 Invalid Address in g:\webs\www.bm3w.co.uk\public_html\ubbthreads\links_submit_link.php on line 93
Could not notify admin

Do we need to set an address somewhere?

Sorry Matt, on holiday. I'll check it out when I'm back home and have access to my computer (1-2 days)

[]MattUK said:
Ah, another problem.. when submitted a new link I get

Warning: mail(): SMTP server response: 501 5.5.4 Invalid Address in g:\webs\www.bm3w.co.uk\public_html\ubbthreads\links_submit_link.php on line 93
Could not notify admin

Do we need to set an address somewhere? [/]

It uses the forum's email address set in the control panel. Double-check that your forum's email address is a current legit one.

Download zip updated to 1.8.3 - a few bugs fixed

One was in the links admin where the admin viewed links submitted, the link to the username didn't work, now it does

Thank you for this Update. The V1.83 is the first version behond 1.5 that will work on my server. But the are 2 typo bugs in links_submitrate_link.php
On Line 39 and 59 you must add \ to the " around the word top or you get an error while trying to rate a link.

Good work !

Thanks for the bugfixes, download zip is updated in the first post

This mod adds search capability to TLD. Links title and description are searched and the found search term is bolded. Perhaps Allen or Josh would be so kind as to integrate my changes into the latest and greatest release because my changes may not include those contributed by other users since I last worked on this script. The integration should be minor because I only changed one script and one template. Enjoy.

Files:

links_search_links.php (new script to go with your other links scripts)
links.php (you may need to modify the path to links_search_links.php)
links_header.tmpl (this replaces links_header.tmpl in your templates/default directory)
search.gif (new icon - this goes in your images directory)

Attached File

128790-TLDLinks.zip (253 downloads)

cool, I'll get it integrated sometime this week and release it as a 2.0

thankyou again

Added a couple of minor fixes:

Added 'no results found' message, previously no message which made you wonder if the script was working.

When bolding search results, script wasn't retaining case. Example: search for 'dallas' would return 'dallas' but it should have returned 'Dallas'.

Links no longer send the URL in the clear.

Attached File

128875-links_search_links.zip (244 downloads)

[]ekempter said:

3. Added a configurable option to specify the minimum number of votes required before a link will appear on the Top Rated page and before the 'stars' ratings will appear next to a link.
[/]

The stars appear in the 'Most Popular' list regardless of how the configuration option is set. Fixed this. Allen, please integrate into the lastest release - this is a very small mod.

Thanks.

Attached File

128876-links_popular_links.zip (286 downloads)

will do - thank you

Zip files updated with the search feature by ekempter -

A few small bugfixes to update it to work with threads 6.5+ and a url fix.

Thanks ekempter, seems to be working real well here

Thank you for this update.

After review the files your should take a look to links_popular_links.php
The header contains wrong version descriptions and in line 58 is an alt tag missing after /images/popular-c.gif\ witch was in your last update.

I have a question about your directory structure for this modification. I put he language files in the UBBt language directory so I have to edit the line

require ("languages/{$myprefs['language']}/links.php");
to
require ("./languages/{$myprefs['language']}/links.php");

in some files. There should be a note in the installation description about the directory location.

This update works very well.

thanks for the bug report, I'll update this this coming weekend with the fixes and look at the language issue too.

Fixed the alt text buglet there and in one other place - zip updated. I don't have an answer for the languages issue yet.

OK Gents - quick question.

I have never used TLD...and basically all I need is an online script that will handle my bookmarks. I get tired of using multiple PCs and managing the bookmarks on each, so I am going to start using my personal site to do so. Easy enough to lock away if I need.

My question is this - should I install this mod on my family's threads site and use it for my personal use, or is this a bit 'robust' for one user? I am sure there are a bunch of random non-integrated bookmark scripts out there, but figured I would start here.

this one is pretty simple to setup, bookmarks would probably be a good use for it

I just added this one to my site (after manually creating the tables). I can't get it to work -every time I submit a link I get:

You have not filled out the form completely. Please hit your back button and try again.

After digging through the scripts that erro is triggered in the links_submit_links.php file by the following code:

Code

 // Check to see if the form was filled out completely <br /> <br />	if (!filled_out($HTTP_POST_VARS)) { <br />		print "<center><b>{$ubbt_lang['LINKS_SUBMIT_FILLED_OUT']}</b></center>"; <br />		$html -> send_footer(); <br />		exit; <br />	}

It looks like the function that checks to see if all of the $HTTP_POST_VARS are avaialble is failing. Any ideas?

good question, it could be that we should be using the same sub threads uses for form submissions

Allen please post the scripts that Threads Dev is using for this hack so I can use Beyond Compare to see what the differences are between the scripts that work here, and the ones in the mod.

we're using the same scripts you find in the first post in this topic. I updated them here when I updated the zips.

The check to see if all of the form data is filled in fails on my site: as written it's always evaluates to false.

Code

 function filled_out($form_vars)<br />	{<br />	// lets make sure that each variable has a value<br />	foreach ($form_vars as $key => $value)<br />		{<br />		if (!isset($key) || ($value == ""))<br />			return false;<br />		}<br />		return true;<br />	}

I can re-write the function to get it to return true, but then I can't get it to fail when a form isn't filled in...

I finally figured out how to fix it -it's not pretty but it works. Since there are only 4 variables that are user selectable I decided to only check for those 4:

Code

 foreach ($HTTP_POST_VARS as $key => $value);<br /><br />// Check to see if the form was filled out completely<br />if ( (!isset($cat_id) || ($cat_id == "")) || (!isset($url) || ($url == "")) || (!isset($title) || ($title == "")) || (!isset($description) || ($description == "")) ) {<br />		print "<center><b>{$ubbt_lang['LINKS_SUBMIT_FILLED_OUT']}</b></center>";<br />		$html -> send_footer();<br />		exit;<br />	} else {

After the else the rest of the script to check the url and enter the data in the database executes.

thanks, that's a new bug not reported before. You must be running a slightly different server setup - is it windows IIS or something?

Original post updated with zip to work with 6.5.2 plus some small bugfixes

my provider changed the webserver a little bit and my TLD2 stop working correct in some functions. It doesnt show any error.

I can enter the main page of TLD. All looks nice and correct. If I click on a category it goes to it but show only every time the same link only (only one and every time the same). It doesn't show me the correct content of the category.

I can click on what I like, I get every time the same result showing me the one and only link and the categorys. The DB contains 138 Links.

Click I 'Most Popular' I see some of my links. If I try to follow a link the redirector show me an empty page (in firefox). In IE it take me back to my board main index.

I try do delete one of the Most Popular links, got the correct message that this link is deleted but after I revisit Most Popular it is still intact and I have 138 links.

If I try to edit a category or link I get the error that not all is filled out correctly.

I can remeber that this problem have to do with global variables or something like this. Anyone who know this effect and have a solution? I like TLD and have to bring it to work again. I need some help.

hmm.. got a link? And did the hosts say what they changed?

The host changes everything

he replace the servermachine include the server software. From Zeus to Lightspeed.

You can take a look on my board on http://www.dragonclan-forum.de/ubbthreads/links.php

But you have to register to access this page.

Strange, have you tried visiting the links admin page and submitting anything?

If I try to submit a link I get: http:// is not a valid url or is temporarily unavailable. Please check the url by clicking on the link and try again.

Seems be related to the post/get bug from Dalantech and maybe Threads 6.5.5 .... I changed the threads version von 6.5.4 to 6.5.5 some days bevore the server changes and not test the TLD *shame*.

/edit: I try to apply the fix for links_submit_link.php from dalantech above, but I ancounter some problems ... still working and cant find out to put it in the right place.

Update: I m on the way. I compare V1.5 to V2.0 and bring some old sript parts to V2. It begins to work but I guess its realy unsafe to XSS. The Links Categories shows now correect, but there is alot more work to do.

/edit: I include in most cases some code like this (example redirector):

PHP Code

 $lid = get_input("lid","get");
	$url = get_input("url","get");

Index works, showlinks work, redirector work. I work on the rest

good deal

Finished, but .....
The problem must be the serversetup. Different servers and different script handling. Based on TLD 1.5 I bring now 90% to work but I feel sick if I takle a look to all the get_input without any check.
This script needs a rework and I hope it will be done for ubb7. Now I have a mix of V1.5, 1.83 and V2(.1) and my user can still work with it.

hehe, I think we'll be re-writing from the ground up for 7 and importing this one's data

Originally Posted by AllenAyres

hehe, I think we'll be re-writing from the ground up for 7 and importing this one's data

Done: https://www.ubbdev.com/forums/ubbthreads.php?ubb=showflat&Number=315098#Post315098