Hello peeps.
Since you're all bored in here I might as well throw in a bone to chew on. I have the final PM hack installed on 5.45c and it works fine - with one minor exception. Every time it hits the limit of 30 messages that I've set, the autodelete kicks in, but it stops with an Internal Server Error. (Which doesn't really provide much clues as to what's wrong.) And, of course, from then on every time you try to open the inbox it'll try to autodelete, and crap out. So you have to be really fast to catch it and stop loading before that kicks in, and manually delete messages.
Everything else, including normal deletion works without any problems. The only problem is autodelete. It's the only thing on my boards that does not function 100%, and while it's not really a major issue, it'd be even better if I could get this fixed so that everything would be working perfectly.
So, any ideas what I could do?
Auto-delete has been known not to work. Can you turn the feature off?
Nope, not that I know of... I suppose the only alternative would be to set the limit to 9999 messages or something...
That has never worked, Ive had a look at it myself looking for a quick fix, but its not easy.
I gave up as I didnt have time to sit there and try and work out how the autodelete works.
i think the problem is the runtime of the script...
can you send me the script via mail? then i can try out what is the matter...
quote:
Originally posted by BassTeQ:
That has never worked, Ive had a look at it myself looking for a quick fix, but its not easy.
I gave up as I didnt have time to sit there and try and work out how the autodelete works.
Damn un-finished hacks. Some still have those annoying bugs in em.
joking-down, I'll send it to you ASAP. Do you only need privatedelete.cgi? (I think that's all there is of the delete script. There are many other files in the hack though, and some modification of core ubb files is necessary.)
Kinda weird that this never worked and no one even bothered to mention it in the docs.
Gladius, Id recommend sending all the files, this way it helps when you are trying to work out the flow of the scripts.
Cheers
Gladius, Id recommend sending all the files, this way it helps when you are trying to work out the flow of the scripts.
Cheers
He already let me know which others he needs too... I suppose if nothing can be done to fix autodelete, it wouldn't be hard to implement a limit so that once you reach the set amount of messages you can't receive any more until you delete some?
Yeah I dont think that would be too hard, you would just need to check the username.count file, and dont let the user send a message if their count is higher then X.
Actually Ill have a look at that soon and let you know the results!
autodelete works !
the only Problem occurs on Unix machines while executing the autodelete part in privatedelete.cgi but the PM are deleted. On Windows NT all works fine
I also found a problem when configuring the settings to "no outbox". In this case the PM's which are sent should not be stored in the .db of the sender (I think so!?) but it's stored everytime and the autodelete will not work when "no outbox" is configured. I found this error on my board for some users who has configured "no outbox" with 4 PM in the inbox and 300kb big $username.db !
autodelete from PM 3.8 only works when configuring "single page". all other configuration will not be autodeleted !
I coded the last 8 hours on PM 3.8 to get rid of the problem.
When my "betatest" are finished I will post the modifications to get it run
That would be great, let us know how you go.
Autodelete never worked for any setting, anywhere on my UNIX server.
Anyway, that guy that I mailed above never got back to me after I sent him the files so I'm supposing he's not working on it, so BassTeQ, I'd welcome your solution. (Or this new one, if it doesn't require a new install of the PM hack.)
[edit]
delete code because it dosen't work...
[edit]
tomorrow i check the code again....
i found no error in the code...
i think it's a timeproblem on a unix-server. try to limit the PMs a user can receive
Can't find the solution either. Is the author of it still around? He'd know his hack the best.
I tried that, but he's not supporting it any more. So, BassTeQ, wanna give it a shot?
Ok, Ive done some coding, and my solution was to not let the user send any messages if their message count exceeds the maximum. They must delete excess messages to be able to send a message. So it forces them to clean up their inbox
If you want the code let me know.
Thats some clever thinking BassTeQ.
Of course I want the code. Glad to see my idea worked out!
I'll PM your my mail.
Ok, in privateseng.cgi
Find:
[/code]Replace with:
[code]
Thats pretty much it!
See how that works for you
Thanks, I'll try it out and let you know. Btw, where do you check your own PMs on this board? I've searched all around but couldn't find a PM strip even on the front page of the boards.
Hmm, wait. What message does someone who wants to send a PM to someone with a full inbox get?
This will come up:
The allowed limit of messages you can store is (Number of PM allowed here) You cannot send any more Private Messages until you delete old ones from your Inbox/Outbox.
Um... I can see that being OK for the one who is trying to send more messages while already having his inbox/outbox full.
But what about when someone is trying to send someone with a full inbox a new PM? What notification does the sender get then? Because I see only one notice in the script there, where there should be two, one for someone trying to send OUT of a full inbox/outbox and one for someone trying to send TO a full inbox/outbox. Or did I get something wrong?
The code only applies to privatesend.cgi.
So the person with a full inbox/outbox can still receive messages, he/she just cant SEND them!
Sorry I got that mixed up Gladius. I thought you meant the sender not the reciever.
No problem. Glad we got that cleared up. Very elegant solution, I think.
I'll install the hack later today.
Ok, implemented it. Seems to work like a charm. Thanks!
Glad to hear it, one small bug which I found in it, was having a problem when replying to messages.
Look in my code above, where it says
[/code]Change that to:
[code]
Enjoy!
Heh, that's great. I just came here to report this same thing and you've already got it.
Thanks again.
Hmm, here's another more or less bug (or oversight), but I suppose this is from the original hack... When you're not logged in (i.e. unregistered or unrecognized), and try to send someone a PM from their profile or post via the
http://etc.etc./privatesend.cgi?sendto=UserName , the server will return an internal server error.
Is there any way to turn this into a notice that you're not able to send PMs unless logged in or registered? So that it doesn't seem broken to unreg'd/unrecognized users. Just a task for the local code wizz's.
Do you mean a PM or IM, because they are two different hacks?
I think you mean PM, either way all you would have to do is check for a valid cookie on the users side, and if it exists show them the msg screen, otherwise show them an error message ?
Ill a play with my board and see what I can do.
PM only currently... but I do intend to install the IM hack on it too. (It requires PM first afaik.)
So if you come up for a solution for both (if the same thing happens with IM), it'd be cool.
Ok, im a little busy at the moment buy when I get some spare time Ill look into it
Ok found a bit of spare time
Heres the fix
In privatesend.cgi find:
[/code]After that ADD:
[code]
Ive tested it and it works fine.
Great stuff... I really appreciate your work. Thanks.
Here... Installed it and it works fine.
Oh btw... Could you do another small fix? The ' character like in "Topic's Title" is simply ignored by PM for some reason... It'll show in the subject line as "Topics Title". I got this when I try to PM someone from inside a topic that has such a subject.
Hrmm thats strange, I just sent a test PM on my board with ' in the subject like. ie
subject: this's a's test's
and it worked fine
Nope, it works fine if YOU do it... Check this out:
1. find a thread which has an apostrophe in the subject like "I'm Hot"
2. send someone INSIDE it a PM with via the PM button in their post
3. check the Subject: field where it autoinserts the name of the topic, it'll be "Im Hot"
This is what I'm talking about.
Ahh ok, I see, let me have a look at the code, ill get back to you.
Ok if you look in ubb_library2.pl for this section.
[code][/code]You'll see the 6'th line removes that symbol from the link. If you like I suppose you can comment it out then it will work as you want it to.
Let me know how you go.
Thanks! But that's weird... Why did they remove all those chars at all in the first place? I'd remove everything but the ampersand, since that's the only one where it (sometimes) makes sense to ignore it... But usually not even that.
How would I remove the whole thing?
Change this
[/code]To this, (note it will strip the ampersand character & )
[code]
Thanks! And if I want the amp out too, I just comment out the $codedsub =~ tr/&/|AMP|/; as well, right?
Thanks!
Oh btw... It didn't work.
I've noticed that when you use the PM icon in a user's post, any of those chars get replaced with a pipe in the link itself, like privatesend.cgi?sendto=Sir+Yerril+of+Morningmist&subject=Re:+I|m+back
Instead of "I'm back" it puts a pipe there...
Im quite busy right now, but ill have a look at it again for you.
Too bad the word censor is not integrated into this hack......