Previous Thread
Next Thread
Print Thread
Rate Thread
Joined: Apr 2000
Posts: 29
Member
Member
Offline
Joined: Apr 2000
Posts: 29
If you upload a file containing spaces, like:

Foo Version 2.0.tar.gz

w3t is "trusting" the filename it gets from the browser, which can be problematic if the filename contains spaces, slashes, colons, high-ascii, etc. none of which are permitted in the file portion of the URL (or which can very much confuse the issue... e.g., my mac can have files with "/" in the name, but on a unix machine that will mean something completely different. Just as a unix machine can have "" in the filename, but that will torque things up well on an NT server)

It seems to me that the file-accept code needs to get the filename from the form input, and then "safe it" (first, making sure the filename itself isn't a hook into javascript, etc., then URL-encoding any non-compliant stuff.)

for example, what would happen if the filename you received was:

foo" onClick=document.alert(document.cookies) BORDER="1

Seems that if that was accepted as a filename, then it would -- after being mated to the head and tail of the HREF from the w3t script -- form a real HREF that would, when clicked on, spill the cookies to a javascript alert (except that my javascript syntax is wrong because i haven't used it in years)... How to send those cookies elsewhere in javascript is left as an exercise for the reader.

D




Sponsored Links
Entire Thread
Subject Posted By Posted
5.1.5 uploaded filename bug (may also exist w/perl Dredd 01/14/2001 5:49 PM
Re: 5.1.5 uploaded filename bug (may also exist w/perl Rick 01/15/2001 6:59 PM
Re: 5.1.5 uploaded filename bug (may also exist w/ Dredd 01/15/2001 7:16 PM
Re: 5.1.5 uploaded filename bug (may also exist w/ Rick 01/15/2001 7:20 PM
Re: 5.1.5 uploaded filename bug (may also exist w/ Dredd 01/15/2001 7:27 PM

Link Copied to Clipboard
Donate Today!
Donate via PayPal

Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.

Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
Recommended Hosts
We have personally worked with and recommend the following Web Hosts:
Stable Host
bluehost
InterServer
Visit us on Facebook
Member Spotlight
isaac
isaac
California
Posts: 1,157
Joined: July 2001
Forum Statistics
Forums63
Topics37,575
Posts293,931
Members13,823
Most Online6,139
Sep 21st, 2024
Today's Statistics
Currently Online
Topics Created
Posts Made
Users Online
Birthdays
Top Posters
AllenAyres 21,079
JoshPet 10,369
LK 7,394
Lord Dexter 6,708
Gizmo 5,834
Greg Hard 4,625
Top Posters(30 Days)
Gizmo 1
Top Likes Received
isaac 82
Gizmo 20
Brett 7
WebGuy 2
Morgan 2
Top Likes Received (30 Days)
None yet
The UBB.Developers Network (UBB.Dev/Threads.Dev) is ©2000-2025 VNC Web Services

 
Powered by UBB.threads™ PHP Forum Software 8.0.1
(Snapshot build 20240918)