UBB.Developers Forums Community Development Programming PHP and Server-side Scripting Random access to array...

I'm writing a script to do random signatures for the ubb board. They way it works is, the program searches the signature for the string "[RANDOM]" then replaces it with a phrase randomly chosen from a text file.

The problem is that it seems to add posts by unregistered users with the name "6" or "reg" or "reh" at the beginning of the thread and posts by unregistered users with no name afterwords. ALso, in the post, only the first line of the text file is ever used, and other text in the sig disappears.

I've narrowed it down to somwhere in this bit of code:


any ideas? Sorry if it's a bit of a bad description.. not thinking clearly right now..

------------------
Programming today is a race between software engineers striving to
build bigger and better idiot- proof programs, and the Universe trying
to produce bigger and better idiots. So far, the Universe is winning.

I have a question. Are all the random signatures on one file? or are they on seperate files? That $SigFile variable makes me think you have it on seperate files. I think i'd be better to have them on one file.

------------------
My Site

My Board

not quite sure what you mean by the question?

All of the different signatures for a particular user are in one sig file. Each user has their own file.

the $SigFile variable just defines the name of the file, which is based on the user's number. (000000002.ran, or somesuch)

------------------
Programming today is a race between software engineers striving to
build bigger and better idiot- proof programs, and the Universe trying
to produce bigger and better idiots. So far, the Universe is winning.

Oh, I see a problem

return @UserSigs[$num];

should be

return $UserSigs[$num];

------------------
* My Site
* My Board
* = No longer exist!

zanardi -- I don't believe that is the problem. I believe you can call it with the @, but it is bad coding technique. In fact, I believe that the UBB does that somewhere in the its coding...

NightHawk The Sane -- Care to zip up the entire script and email it to [email protected]? I can take a look at it and see where the problem is.



------------------
Da Wannabe Cannuck

:: Who is Andy?

That and it's just plain wrong.

$blah[something] is an array element
@blah[something] is an array slice.

While it's possible to get the same result with using either, it's not a good idea. It's a good idea to read up on the differences.

--mark

yea, the @ is bad coding, I know that.
But that's not the problem

atom, sorry for the delayed response, thank's for your help. I'll email what i have to you right now...

------------------
Programming today is a race between software engineers striving to
build bigger and better idiot- proof programs, and the Universe trying
to produce bigger and better idiots. So far, the Universe is winning.