UBB.Developers Forums Community Development Programming PHP and Server-side Scripting Whats wrong with this?

It's supposed to be a link script but it only shows "Add a Link" and when I try to add one it tries to submit to "a=add&var=false" and not "var=true".
shareit.cgi:

links.cgi:

------------------

You're confusing the CGI perl module by declaring $var to be a 'form' value, and a URL value.

The structure is a little messy too, here's something to think about.

This is far, far from perfect:

#!/usr/bin/perl -wT


# Made by me for me but you may use it. If it crashes your sever I take no responsibility
# v1.0 by Em8
# Copyright(C) 2000


use CGI;
use strict;
use Fcntl qw(EFAULT :flock);

my $q = new CGI;

my $a = $q->param('a');
my $var = $q->url_param('var');

print $q->header();

if ($a) {

main() if $a eq 'main';
submitlink() if ($a eq 'add' and $var eq 'false');
make() if ($a eq 'add' and $var eq 'true');

} else {
main();
}


sub main {
open LINKS, ' flock LINKS, LOCK_SH or die $!;
while ( ) {
@_ = split /|!|/;
print qq(
$.: $_[1] $_[6]

---

>

$_[2]

$_[4]




);
}
close LINKS or die $!;

print "

Add A Link

";
}

sub submitlink {

print $q->startform (-uri=>'www.yourdomain.com?var=true',-method=>'post');
print<
Enter Your Name:

Enter Your Website URL:

Enter Your Website Name:

Comments about your wedsite:



ENTER
}

sub make {
# Print the file

my $T1 = $q->param(Maker);
my $T3 = $q->param(URL);
my $T2 = $q->param(Name);
my $T4 = $q->param(About);
my $T5 = $ENV{'REMOTE_ADDR'};
my $T6 = localtime();

open THIS, '>>links.cgi' or die $!;
print THIS "$T1|!|$T2|!|$T3|!|$T4|!|$T5|!|$T6n";
close THIS or die $!;
}

This message has been edited by Matt@ikonboard on December 21, 2000 at 12:31 PM

Your logic in sub main is incorrect. You're reading the contents of the file into @vlink, then changing vlink to be the contents of grepped lines from @links (which doesn't exist). So now @vlinks is empty.

You theh assign the vars like $Maker, $Name etc to the different elements of @vlink (which is empty, so all these vars are now empty) and once you've assigned each part of the @vlinks array, you then foreach through it? Plus when you do your variable assignment, you're starting at 1. First element in the array should be 0

You need to diagram your flow on paper, then code to follow what you're trying to do

To give you a start, I *think* this is what you're looking for, for sub main:


--mark

Scratch all that, I've just figured what you're trying to do.


This message has been edited by Matt@ikonboard on December 21, 2000 at 12:57 PM

would this mean to replace "use strict;" with "use strict qw(vars);"?:
------------------

When I try that I get: Line 25 is: print qq(
Line 18 is: $Mode{$act} ? $Mode{$act}->() : ShowLinks();

------------------

You'll need to single quote the 'param('word') stuff.

Don't worry about those spurious warn's - it's there to let you know of possible error's (syntax, and/or logical) - even the CGI perl module turns off warnings in places.

Got it:
http://opena.virtualave.net/cgi-bin/shareit.cgi?

------------------


This message has been edited by Em8 on December 21, 2000 at 08:35 PM