|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
Name: PM Folders 1.0 Beta Description: Allows users to have a inbox, sent and trash can to put their PM's into as well as up to 15 custom folders. This also dramatically changes the layout of the 'my profile' page. Special Thanks: BassTeQ Download: https://www.ubbdev.com/ubb/upload/00006378/pm_folders.zip Demo: http://wwww.pavioni.com/cgi-bin/ubbcgi/ultimatebb.cgi User: ubbtest Pass: test To Do: - Add code to sort pm's in folders through subjects, date and users. - It's 99% wordletized now, gotta get that 1% Notes: - Though i've been testing this alot with success, i would not rule out bugs which is why this will be beta for awhile. - The pictures in the demo are not showing because of permissions i need to take care of and do work in the script. - This hack does not modify the pm topic or data hashes, just adds a hash on to it, so removing it will hold no problems. - 
|
|
|
|
Joined: Mar 2001
Posts: 7,394
Admin / Code Breaker
|
Admin / Code Breaker
Joined: Mar 2001
Posts: 7,394 |
Again, great job! 
|
|
|
|
Joined: May 2001
Posts: 50
Member
|
Member
Joined: May 2001
Posts: 50 |
Sweet hack however how will this interact with the Private Message Notice hack (PM notice on the front page of the fourm summary)? I Guess I should hack it in, and see for myself rather than asking the question 
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
Thanks LK! Fahd: This hack doesn't even touch any forum_summary files, nor does it affect the data touched by the PM notice hack. There's no possiblity that this hack will interfere with it. 
|
|
|
|
Joined: Oct 2002
Posts: 394
Enthusiast
|
Enthusiast
Joined: Oct 2002
Posts: 394 |
Brett, There is something wrong with the display on the Profile page, nothing ligns up with my style template and it conflics with my footer. Once I click on any of the folders (Inbox, Sent, Trash) everything looks perfect! Can you have a quick look and let me know what coul'd be the issue here? URL login: test pass: test Other than that everything is beautiful! Good job! Thank you, Felix
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
This looks like a really nice hack, Im looking forwad to installing it!
Thanks
I can't afford a good signature editor
|
|
|
|
Joined: Mar 2000
Posts: 21,079 Likes: 3
I type Like navaho
|
I type Like navaho
Joined: Mar 2000
Posts: 21,079 Likes: 3 |
suweet! Thank you brett 
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
hey Felix 10, i think i see the problem, i missed placed a $TBB in the wrong place. I believe i fixed it. Redownload the zip and upload the public_pm_folders_summary.pl Your all very welcome 
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
I've noticed a problem, when you are in the inbox say, and on the right hand side, in the drop down box, select another folder and hit Ok, it doesnt work. Im looking into at the moment.
I can't afford a good signature editor
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
Hmm... This is meant to be a 'mover' where selected items will be moved to another folder with that button, but hey! What if, if you have nothing selected, it'll take you too another folder? I'll go ahead and work that in. EDIT: (ZIP Updated) Got it in, had to use a javascript refresh. The only change there was in ubb_folders.cgi.
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
Ahh Ok, my bad Maybe should put some wording there, Move to: then the option box dropdown.
I can't afford a good signature editor
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
Done and wordletized 
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
Great, Also Im getting a page not found when trying to move/delete a message ? Are you getting that also?
PS. Are you on ICQ ? We can discuss a few other issues Ive picked up there.
I can't afford a good signature editor
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
|
|
|
|
Joined: Oct 2002
Posts: 394
Enthusiast
|
Enthusiast
Joined: Oct 2002
Posts: 394 |
I rehacked everything, still a couple of issues.It works rather strange 1. even though I have no new messages the Inbox shows 3 messages, as many as I had before deleting. 2. new messages go straight into the Trash 3.messages received all come from Me to Me, no sender name. 4. no way to tell if a message was read or not. 5. messages Sent should show TO WHO not FROM, it was, obviously, sent by you, the user.
Plus some weird messages saying that a message cant be moved into the same folder when you try to move it to Trash from Inbox.
are these issues fixable? or just disable the hack, members are annoyed by this good looking feature but not working propely.
Thanks, felix
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
What do you mean the same thing ?
The errors brett it working on now are
1. Cant delete from the inbox
2. Incorrect message counts showing when you move a message
3. Which I havent told him about yet, is that there is a prob when deleting/moving messages in a custom defined folder.
Only small bugs though that need ironing out.
I can't afford a good signature editor
|
|
|
|
Joined: Oct 2002
Posts: 394
Enthusiast
|
Enthusiast
Joined: Oct 2002
Posts: 394 |
quote: Originally posted by BassTeQ: What do you mean the same thing ?
The errors brett it working on now are
1. Cant delete from the inbox
2. Incorrect message counts showing when you move a message
3. Which I havent told him about yet, is that there is a prob when deleting/moving messages in a custom defined folder.
Only small bugs though that need ironing out. Read my post above BassteQ, there is a whole list of them. I rehacked everything twice, and trust me there isn't much margine for error, cant make a mistake in hacking those only two files, even a beginner like me gets it easy. Thanks
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
hehe quite true, it is a n easy hack, I had a look at your board, you profile page seems to line up ok, I cant see whats not lined up. As for the issues you pointed out I know brett is aware of a few of them, the others I never noticed, like the 'from' field. Anyways I'm sure brett will fix these all in good time. ------------------------------------------- Ive found the problem to it displaying your name, not who the message came from. Also will now show wether or not the message has been read by the receipient. In file public_pm_folders_review.pl Find: code:
if ($to eq 'yes') { my $read_marker_1 = ''; my $read_marker_2 = ''; } else { my $read_marker_1 = "<b>"; my $read_marker_2 = "</b>"; }
my($f, $t) = split(/./, $folder); my $from_or_too = ($in{f} eq 'sent') ? $username : &get_public_name($to); my $formatted_time = &DateFormat($date) . " " . &TimeFormat($time);
Replace that with: code: [qb] if ($in{f} ne 'sent') { if ("$read" eq "yes") { $read_marker_1 = ''; $read_marker_2 = ''; } else { $read_marker_1 = "<b>"; $read_marker_2 = "</b>"; } }
my($f, $t) = split(/./, $folder); $from_or_too = &get_public_name($from) if ($in{f} eq 'inbox'); $from_or_too = &get_public_name($to) if ($in{f} eq 'sent'); my $formatted_time = &DateFormat($date) . " " . &TimeFormat($time); if ($in{f} eq 'sent') { if ($from eq $user_number) { if ($read_to eq "yes") { $ReadReciept = $vars_wordlets{pm_sent_recip_read}; } elsif ($read_to eq "no") { $ReadReciept = $vars_wordlets{pm_sent_recip_unread}; } else { $ReadReciept = $vars_wordlets{'pm_sent'}; } } else { $ReadReciept = $vars_wordlets{'pm_received'}; } $ReadReciept = qq| <i>( $ReadReciept )</i> |; } # End If sent folder [/qb] Find: code:
$read_marker_1 $from_or_too $read_marker_2 $user_profile{15}
Replace that with : code: [qb]$read_marker_1 $from_or_too $read_marker_2 $user_profile{15} $ReadReciept [/qb] -------------------------------------------- Also the sent box says FROM in the heading when it should say 'Sent to'. To fix this. Open public_pm_folders_review.pl Find: code:
# standard top of HTML page print "$Header";
Add below: code: [qb]$vars_wordlets{author_from_colon} = $vars_wordlets{author_to} if ($in{f} eq 'sent'); [/qb]
I can't afford a good signature editor
|
|
|
|
Joined: Dec 2000
Posts: 12
 Member
|
 Member
Joined: Dec 2000
Posts: 12 |
quote: Originally posted by Felix 10:
are these issues fixable? or just disable the hack, members are annoyed by this good looking feature but not working propely.
Thanks, felix Think thats why its Label'd BETA! Gonna be lots of bugs until ppl test it out and report fixes. Either tell ur members that you are testing it out and ya might run into problems or dont put it up till its all ready..
|
|
|
|
Joined: Oct 2002
Posts: 394
Enthusiast
|
Enthusiast
Joined: Oct 2002
Posts: 394 |
quote: Originally posted by BassTeQ: hehe quite true, it is a n easy hack, I had a look at your board, you profile page seems to line up ok, I cant see whats not lined up.
As for the issues you pointed out I know brett is aware of a few of them, the others I never noticed, like the 'from' field.
Anyways I'm sure brett will fix these all in good time.
BassTeQ, the template is fine now after Brett quickly repairedred the missplaced a $TBB in the public_pm_folders_summary.pl Now, as far as the other, I am sure Brett will read these, this is the feedback with a small list of small bugs. I am certain that Brett is already awared of these. 1. The SEND folder still does not show TO is only shows FROM which is wrong. Obviously I am the sender, I need to know TO WHOM the PM was send. 2. Moving PM's from INBOX and SEND Folder is still not working 3. Deleting in block gines you the error message: "You cannot transfer messages to the same folder!" 4. Deleted PM's still show as a number in the box. 5. There is no feature to if a PM was whether read by the recepient or not Please understand, I am not being critical I am just trying to help pointing things that need attention because I had the time to check this and the simple reason that I love it! If you need to see those again, by all means. URL login: test pass: test
|
|
|
|
Joined: Oct 2002
Posts: 394
Enthusiast
|
Enthusiast
Joined: Oct 2002
Posts: 394 |
quote:
Originally posted by Raichu Babai: quote: [qb]Originally posted by Felix 10:
are these issues fixable? or just disable the hack, members are annoyed by this good looking feature but not working propely.
Thanks, felix[/qb] Think thats why its Label'd BETA! Gonna be lots of bugs until ppl test it out and report fixes. Either tell ur members that you are testing it out and ya might run into problems or dont put it up till its all ready..
Babai, I know. I am aware that, as a Beta, still have to go through a fine comb But I cant stop using it as is, it was love at first sight Thank you
|
|
|
|
Joined: Jun 2001
Posts: 729
Coder
|
Coder
Joined: Jun 2001
Posts: 729 |
The updated profile page is missing the rating of other users. Can this be put back in?
Otherwise incredable job!!!
|
|
|
|
Joined: Oct 2002
Posts: 394
Enthusiast
|
Enthusiast
Joined: Oct 2002
Posts: 394 |
quote:
Originally posted by BassTeQ: hehe quite true, it is a n easy hack, I had a look at your board, you profile page seems to line up ok, I cant see whats not lined up. As for the issues you pointed out I know brett is aware of a few of them, the others I never noticed, like the 'from' field. Anyways I'm sure brett will fix these all in good time. ------------------------------------------- Ive found the problem to it displaying your name, not who the message came from. Also will now show wether or not the message has been read by the receipient. In file public_pm_folders_review.pl .........
YES ! getting there, a few minor adjustments and that is it! Looks great. Quick question. In Private Message Inbox Folders table The Text on the Header Strip is Black even though my template's Table Header Strip Text Color is White According to these lines in your public_pm_folders_summary.pl code: [qb] $TBT <tr bgcolor="$vars_style{TableColorStrip}"> <td colspan="2"> <b><font size="$vars_style{TextSize}" face="$vars_style{FontFace}" color="$vars_style{TableStripTextColor}"> $vars_wordlets{my_profile_header}: $pubname </font></b> </td> </tr> [/qb] It should match the template color but it does not. Any ideas what is wrong? Thank you.
|
|
|
|
Joined: Sep 2001
Posts: 93
Member
|
Member
Joined: Sep 2001
Posts: 93 |
thx. for this very nice hack but in the inbox the pms seem not to be sorted by incoming date, is there any known bug ?
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
Hey sorry i had to leave there yesterday. I went to my parents house for thanksgiving(they don't have a computer there) and won't be back to my apartment until tomorrow, but i'm doing a site for my old employers and may have some time to get something done here since i brought my hard drive. I have read through and through and will hopefully get something done today if not tomorrow. I hope to get rid of the major errors first and then work on the little ones. I could have sworn that if was working fine when i first released it; but now i've gotten these errors too. I guess that's why it's beta.. ^_^ Sorry guys for all the trouble and will hopefully get this done quickly. EDIT: Updated zip with BassTeQ's fixes. (Thanks again!  )
|
|
|
|
Joined: Aug 2001
Posts: 103
Member
|
Member
Joined: Aug 2001
Posts: 103 |
http://coloradof-body.com/cgi-bin/ultimatebb.cgi I've created an account: Logon: Test Account Password: Test Account If you look at the main page of the bullein board, the sponsor links are on the right on the page, but going into the Profile page, the links are all shot down at the bottom left? Any fixes?
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
Welp, updated zip with some fixes, 'hopefully'. - Deleting PM's done right this time - Member Ratings show correctly - Correct PM count and size for inbox/folders/etc... - PM's now ordered from newest to oldest EDIT: BassTeQ and I just went through the entire thing and can safefully say that we couldn't find any more errors. *crosses fingers*
|
|
|
|
Joined: Nov 2001
Posts: 1,704
Moderator / Da Masta
|
Moderator / Da Masta
Joined: Nov 2001
Posts: 1,704 |
Dude. I love this. Nice work brett 
|
|
|
|
Joined: May 2001
Posts: 50
Member
|
Member
Joined: May 2001
Posts: 50 |
Still a few bugs left... A user can't delete custom folders, and if you create them it seems that the first message in your inbox will be replicated in the new folder. That is until you do anything to this "ghost" message (e.g. move, it delte it) where-apon the original message from the inbox will be moved/deleted and the "ghost" message will disappear. Also messages from the sent folder are delted straight-away (without being moved to the trash folder). I'm assuming that's intentional, although a warning to users would be a good idea (say by the delete button). Other than that very cool so far 
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
quote:
Originally posted by Fahd: Still a few bugs left...
A user can't delete custom folders, and if you create them it seems that the first message in your inbox will be replicated in the new folder. That is until you do anything to this "ghost" message (e.g. move, it delte it) where-apon the original message from the inbox will be moved/deleted and the "ghost" message will disappear.
Hrmm stange, Im running it on my test / production boards and on both I dont experience any of these issues. quote: [qb] Also messages from the sent folder are delted straight-away (without being moved to the trash folder). I'm assuming that's intentional, although a warning to users would be a good idea (say by the delete button).
Other than that very cool so far [/qb] This is intentional for the time being, the sent items use a different hash and brett said that he may look into a fix for that in the future.
I can't afford a good signature editor
|
|
|
|
Joined: Nov 2001
Posts: 170
Member
|
Member
Joined: Nov 2001
Posts: 170 |
brett
it is the pest hack thank you
I have a problem 1- I can't delete a custom folder 2- When I move one pm from inbox it move all the pm in the inbox to the custom folder and it show the count in both folder the same number and when I open both folder I see the same thing. When I empty the custom folder it empty the inbox to
|
|
|
|
Joined: Nov 2001
Posts: 170
Member
|
Member
Joined: Nov 2001
Posts: 170 |
Mange to find the problem In ubb_folders.cgi find code:
# add it $total_count++; push(@pms, "$count||^||$in{add_name}||^||$in{add_desc}||^||0||^||0");
replace it by code: [qb] # add it $total_count++; push(@pms, "$total_count||^||$in{add_name}||^||$in{add_desc}||^||0||^||0"); [/qb]
|
|
|
|
Joined: Nov 2001
Posts: 170
Member
|
Member
Joined: Nov 2001
Posts: 170 |
Fahd If you have added a custom folder go to member_path/ pm_folders/user_numer.cgi And place 0 in the first place For example the line in member_path/ pm_folders/user_numer.cgi will look something like this ||^||ww||^||||^||0||^||0 replace it by 0||^||ww||^||||^||0||^||0
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
Actually I did find another small bug, it allows you to click Add Folder even if you dont enter a folder name, and it then creates a blak folder. The fix. In pm_public_folders_summary.pl find: code:
function Rename(num) { var ti = prompt("$vars_wordlets{PM_rename_folder}", ''); if(ti && ti != null && ti != "null" && ti != "") { var di = prompt("What would you like this folder's description to be?", ''); document.RenameF.Num.value = num; document.RenameF.Name.value = ti; document.RenameF.Desc.value = di; document.RenameF.submit(); } }
After it Add: code: [qb]function validateForm(theForm) { if ( document.all.add_name.value.length == 0) { alert('Folder name cannot be blank'); document.all.add_name.focus(); return false; } return true; } [/qb] Find: code:
<form name="replier" method="post" action="$vars_config{CGIURL}/ultimatebb.cgi">
Replace that with: code: [qb]<form name="replier" method="post" action="$vars_config{CGIURL}/ultimatebb.cgi" onsubmit="return validateForm(this)" > [/qb] This just adds some simple javascript error checking.
I can't afford a good signature editor
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
Thanks for the fixes and have just uploaded an updated zip. I will get back to work on this to determine the ghost error and delete custom folder error after i get done with something.
|
|
|
|
Joined: Nov 2001
Posts: 170
Member
|
Member
Joined: Nov 2001
Posts: 170 |
Another problem It assume that the public name is the user name. You could use my hack in https://ubbdev.com/ubbcgi/ultimatebb.cgi?ubb=get_topic;f=20;t=000565 To fix this problem by doing the following: in ubb_folders.cgi before code:
sub IN_Folder_Review_Delete_Move {
add code: [qb]sub getpublicnamee{ my $public_names=$_[0]; my $num; my $one; my @line; @all_member_nums; @all_members_list = grep(/d{8}/, &OpenFileAsArray("$vars_config{MembersPath}/memberslist.cgi")); my $count=0; foreach $one (@all_members_list) { @line = split (/|!!|/, $one); chomp($line[1]); push (@all_member_nums, $line[1]); $count++; } @this_member; my $found=0; my @all_members_list2; @all_member_nums2; @all_member_name; my $count2=0; if (-e "$vars_config{MembersPath}/publicmemberslist.cgi"){ @all_members_list2 = grep(/d{8}/, &OpenFileAsArray("$vars_config{MembersPath}/publicmemberslist.cgi")); foreach $one (@all_members_list2) { @line = split (/|!!|/, $one); chomp($line[1]); push (@all_member_nums2, $line[1]); push (@all_member_name, $line[0]); $count2++; } } if ($count2 != $count){ my @public_name_file; THIS: foreach $one (@all_member_nums) { # open profile @this_member = &OpenProfile($one); chomp($this_member[15]); push (@public_name_file, "$this_member[15]|!!|$one"); if ($this_member[15] eq ''){ $this_member[15]=$this_member[0]; } if ($this_member[15] eq $public_names){ $num=$one; } } &WriteFileAsArray("$vars_config{MembersPath}/publicmemberslist.cgi",@public_name_file); chmod(0777, "$vars_config{MembersPath}/publicmemberslist.cgi"); } else { $count=0; THIS: foreach $one (@all_member_nums2) { if ($all_member_name[$count] eq $public_names){ $num=$one; } $count++; } } return $num; } [/qb] find code:
$num = &GetUserNumber($in{username});
replace it by code: [qb] $num=&getpublicnamee($in{username}); [/qb]
|
|
|
|
Joined: May 2001
Posts: 50
Member
|
Member
Joined: May 2001
Posts: 50 |
Cheers guys your fixes for deleting a custom folder have worked. Alos this issue with ghosting messages seems to have disappeared.
|
|
|
|
Joined: Oct 2000
Posts: 743
Moderator / Code Fixer
|
Moderator / Code Fixer
Joined: Oct 2000
Posts: 743 |
One more prob  When you send a new PM , it takes you back to the main forum page, it should take you back to your profile page. This is because the referer value is null. I think its null because these is no {http-referrer} when you click that button, for there to be a referrer you need to click a link. Not sure about how that can be fixed.
I can't afford a good signature editor
|
|
|
|
Joined: May 2001
Posts: 1,042 Likes: 7
Moderator
|
Moderator
Joined: May 2001
Posts: 1,042 Likes: 7 |
The solution would be to replace that $ENV{HTTP_REFERRER} in public_new_pm.pl(i think that's what it's called) to "$vars_config{CGIURL}/ultimatebb.cgi?ubb=my_profile".
|
|
|
|
Joined: Oct 2002
Posts: 394
Enthusiast
|
Enthusiast
Joined: Oct 2002
Posts: 394 |
Sorry for asking again, can anybody please tell me how do I change the black fonts from the Inbox table strip? they are not that visible and dont match my template.
Thank you
|
|
|
Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.
Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
|
|
Posts: 87
Joined: December 2001
|
|
Forums63
Topics37,575
Posts293,931
Members13,824
|
Most Online6,139 Sep 21st, 2024
|
|
Currently Online
Topics Created
Posts Made
Users Online
Birthdays
|
|
|
|