UBB.Developers Forums UBB.classic V5 Mod Questions Speeding up the Openthread sub

This mod speeds up the OpenThread sub routine.
http://www.h-realms.com/openthread.txt
Edit ubb_library.pl

------------------
UBBDEV Moderator
OCCUPATION: Programmer, webmaster.

Hack Developer of the Ultimate Bulletin Board. I am not an employee of Infopop

Due to time limitation, I do not offer support Via. E-mail. Please post on the forums.

Sincerely,
MasterMind

------------------
Da Wannabe Cannuck

:: Who is Andy?

Benchmark: timing 100000 iterations of New, Old... New: 24 wallclock secs (18.30 usr + 2.36 sys = 20.66 CPU) Old: 22 wallclock secs (18.61 usr + 2.15 sys = 20.76 CPU)

------------------
UBBDEV Moderator
OCCUPATION: Programmer, webmaster.

Hack Developer of the Ultimate Bulletin Board. I am not an employee of Infopop

Due to time limitation, I do not offer support Via. E-mail. Please post on the forums.

Sincerely,
MasterMind

Hey MM you gotta tell us where to change the code you know...which files do we edit?

------------------
The Fusion of Goku & Trunks...GoTorankusuKu

ubb_library.pl

------------------
UBBDEV Moderator
OCCUPATION: Programmer, webmaster.

Hack Developer of the Ultimate Bulletin Board. I am not an employee of Infopop

Due to time limitation, I do not offer support Via. E-mail. Please post on the forums.

Sincerely,
MasterMind

Nice!

...Another great "Speed" hack by MasterMind-!
...and Atom911-!

edit = forgot a name

------------------


Liquid FX Design.com | Ghoste.com | AuctionVilleUSA.com
GamingRC.com | ThrillKillClan.com

This message has been edited by Ghoste on November 20, 2000 at 03:18 AM

BEWARE!

If you are using an older version such as 5.39, this code will destroy a thread.

It will delete EVERY POST preceding a new one, and the TOPIC will vanish.

Nothing Major then?
Q: What changed hugely about the thread storage structure from the older version that this mod wrecks?

5.39 code:

sub OpenThread {
my $ThreadFile = shift;

@forumfacts = &GetForumRecord($number);
$ThisRestrict = $forumfacts[6];
$ThisPassword = &decodeURL($forumfacts[7]);

if ($ThisRestrict eq "private") {
$ExactPath = "Forum$number/private-$ThisPassword";
} else {
$ExactPath = "Forum$number";
}
if ($ThreadFile =~ /^dddddd.cgi$/) {
open (MESSAGE, "$ForumsPath/$ExactPath/$ThreadFile");
my @mess = ;
close (MESSAGE);
my @threadguts = sort(@mess);
return(@threadguts);

********************************
New code(pre-hack):
sub OpenThread {
my $ThreadFile = shift;

@forumfacts = &GetForumRecord($number);
$ThisRestrict = $forumfacts[6];
$ThisPassword = &decodeURL($forumfacts[7]);

if ($ThisRestrict eq "private") {
$ExactPath = "Forum$number/private-$ThisPassword";
} else {
$ExactPath = "Forum$number";
}

if ( ($ThreadFile =~ /^d{6}.(cgi|ubb)$/) || ($ThreadFile =~ /^d{6}-d{6}-d{6}-d{6}.(n|m|msg|nmsg)$/) ) {

open (MESSAGE, "$ForumsPath/$ExactPath/$ThreadFile");
my @mess = ;
close (MESSAGE);
my @threadguts = sort(@mess);
return(@threadguts);

NB:

What are you talking about here? It will destroy what thread? Should be use the code that you have listed (the pre hack one) or what?

I haven't noticed anything happening odd on my board since installing this.

Parker

Parker: I think that NBAustin is just answering Borg_5x8's question. Revuew it and you'll see.

If you have a UBB that is no later than 5.39, you shouldn't need to worry, I guess...

------------------
Tolitz (Canis Lupus)
Webmaster/Administrator
Open Tech Support

Actually,

The newer versions should be OK. I don't know in which version the code was changed.

MM,

Will this work if I susbstitute this:

if ( ($ThreadFile =~ /^d{6}.(cgi|ubb)$/) || ($ThreadFile =~ /^d{6}-d{6}-d{6}-d{6}.(n|m|msg|nmsg)$/) ) {


with this?

if ($ThreadFile =~ /^dddddd.cgi$/) {


Evidently this is where the problem lies for older versions such as mine.

What does this mean? The cpu result is .1 cpu faster... is that significant? It's looks to make it <.5% faster...

Not slamming the modification, just wondering what the difference is...

------------------
Allen

- http://www.stand318.com

To support AA, I don't understand the numbers. From what I see, it takes the new code 24 unofficial seconds and 20.66 cpu cycles to run the 100000 iterations, while the old code takes only 22 unofficial seconds and just .01 of a cycle more to run the 100000 iterations.

Am I mis-reading something? Or is it trading off cpu work for speed?

------------------
Mike
------------------
Visit STCC: stcchat.com

You'll notice a medium or small speed increase. Please excuse that benchmark. It is wrong.

NBA,
If you substitute those it should work fine. But i dont know when the version changed. Not many people use old versions, and I will not support older versions.



------------------
UBBDEV Moderator
OCCUPATION: Programmer, webmaster.

Hack Developer of the Ultimate Bulletin Board. I am not an employee of Infopop

Due to time limitation, I do not offer support Via. E-mail. Please post on the forums.

Sincerely,
MasterMind

Thanks MM.

I understand not supporting old versions. I appreciate the answers you give as needed.

Ok, I added this mod and one other speed-up mod. Now, My "New Topics Posted Today" displays nothing.

These are the only two mods I have installed recently and everything was fine until now. Anyone have any ideas?

I think it's the "other" speed up hack. I heard one of them caused problems.

------------------
The Fusion of Goku & Trunks...GoTorankusuKu