UBB.Developers Forums UBB.classic V5 Mod Questions Bug Fix For All 5.4x Versions

This is a fix from a thread written by Rob Carnell, which is presently located here:

http://ubbforums.infopop.com/cgi-bin/ultimatebb.cgi?ubb=get_topic&f=16&t=001378


Affected files in version 5.47e are cpanel3.cgi and ubb_library2.cgi.

Affected files in version 5.47e are cpanel3.cgi and ubb_library2.cgi.[/b][/QUOTE]


Okay, I hope this is not a stupid question! What exactly are we supposed to do?

Thanks!

So are you saying that the problem is in the double = in the For statement and that the if statements are fine?

For example:

for ($eachpage == 1; $eachpage <= $TotalPages; $eachpage++) {
if ($eachpage == 1) {
$PageName = "$ThreadNumber";
} else {
$PageName = "$ThreadNumber-$eachpage";
}
if ($PageNumber == $eachpage) {

should be:

for ($eachpage = 1; $eachpage <= $TotalPages; $eachpage++) {
if ($eachpage == 1) {
$PageName = "$ThreadNumber";
} else {
$PageName = "$ThreadNumber-$eachpage";
}
if ($PageNumber == $eachpage) {

or do I need to change the double = in the if statements too?

Parker

Exactly. You only need to alter the first line.

Change the double equals (==), which is a logical comparison and not an assignment, to a single equals (=).

for ($eachpage == 1; $eachpage <= $TotalPages; $eachpage++) {

Becomes

for ($eachpage = 1; $eachpage <= $TotalPages; $eachpage++) {

Open all the CGI files in your favourite advanced text editor and do a search and replace. That'll fix everything and will only take a second or two.

[ May 13, 2001 04:52 AM: Message edited by: Shockwave ]

Before I set out removing all the "==" a little more explanation would be helpful.

When should the double equals sign be used?

When should it not?

You mentioned that a single = should be used in comparative situations, is this true for all such situations?

(spaces have been added so this can post)

As an example ( from the announce file ):
if ( document . cookie ) {

if ( testUserName == null ) {


That is comparing right, so you are saying it should only be one equals sign?

If this is the case then they are all over the place.

It would also seem that you are saying a double = is used for assignments only, such as X==Y yet all over the place they used only one equals sign?

A bit more clarification would be helpful, please.

Just this line:

for ($eachpage == 1; $eachpage <= $TotalPages; $eachpage++) {

It should be:

for ($eachpage = 1; $eachpage <= $TotalPages; $eachpage++) {

I think he means that u change the fisrt == in a line to one =.

why should I change, in a for loop, it's supposed to do compare first do do ACtion right? single = is an assignment right??

What are ya talking bout?

Perl has a C like syntax designed for computers, not humans - hence this sort of coding error gets made even by the best programmers.

In the for statement, the first part is the initialize, then the comparison, then the increment. So the error was to have two comparsions using ==.

I prefer languages where the = sign means assign or compare and the context of the statement will determine it automatically.