Suggestion about your scripts - 04/15/2000 6:06 AM
Hi, there.
First, your wwwthreads is very well. Keep going!
Second, I have some suggestion:
1. Although your scripts are written with use strict, you should use perl -w to check it. As I remeber, some scripts will give you some warning. And also, when you debug it, you'd better use #!/usr/bin/perl -w. And try the best to avoid warning.
Hard work
2. When running in mod-perl, your script will disturb the whole server and affect my other mod-perl script. Since it's not my server, I can not tell you the detail information. But the server's adminitrator told me that when he try your bbs, his server runs in a strange status.
3. When you use sql request, you'd better put $sth->prepare outsite loop. DBI's prepare need too many time and in most of enviroment, you do not need to do that. You can use $sth->execute($values) in the loop to run the sql request. I also found that you use a lot of $dbh->quote(),,, you can also use ? in the sql syntax and use execute(...) to replace them. Just a suggestion
4. Your old addpost.pl will lock in my window system, and some times, in linux server. I have replaced it with CGI.pm. (Your getfile function has some problems). Maybe you have fixed it.
5. When you upgrade your scripts, could you please give us the list of scripts you modified? I have modified a lot of your scripts. Everytime, you upgrade it and said there are some security bugs, I have to upgrade it and redo a lot of work...... It's not funny. :(
6. The bbs should has a digest features to store some good articles. If you do not do that, I have to write one by myself.
Ok, that's all. Keep your good job!
Billow
First, your wwwthreads is very well. Keep going!
Second, I have some suggestion:
1. Although your scripts are written with use strict, you should use perl -w to check it. As I remeber, some scripts will give you some warning. And also, when you debug it, you'd better use #!/usr/bin/perl -w. And try the best to avoid warning.
Hard work2. When running in mod-perl, your script will disturb the whole server and affect my other mod-perl script.
Since it's not my server, I can not tell you the detail information. But the server's adminitrator told me that when he try your bbs, his server runs in a strange status. 3. When you use sql request, you'd better put $sth->prepare outsite loop. DBI's prepare need too many time and in most of enviroment, you do not need to do that. You can use $sth->execute($values) in the loop to run the sql request. I also found that you use a lot of $dbh->quote(),,, you can also use ? in the sql syntax and use execute(...) to replace them. Just a suggestion
4. Your old addpost.pl will lock in my window system, and some times, in linux server. I have replaced it with CGI.pm. (Your getfile function has some problems). Maybe you have fixed it.
5. When you upgrade your scripts, could you please give us the list of scripts you modified? I have modified a lot of your scripts. Everytime, you upgrade it and said there are some security bugs, I have to upgrade it and redo a lot of work......
It's not funny. :(6. The bbs should has a digest features to store some good articles. If you do not do that, I have to write one by myself.
Ok, that's all. Keep your good job!
Billow