Previous Thread
Next Thread
Print Thread
Rate Thread
#204579 04/14/2000 11:06 PM
Joined: Aug 2000
Posts: 3,590
Moderator
Moderator
Offline
Joined: Aug 2000
Posts: 3,590
Hi, there.
First, your wwwthreads is very well. Keep going!
Second, I have some suggestion:
1. Although your scripts are written with use strict, you should use perl -w to check it. As I remeber, some scripts will give you some warning. And also, when you debug it, you'd better use #!/usr/bin/perl -w. And try the best to avoid warning. smile Hard work

2. When running in mod-perl, your script will disturb the whole server and affect my other mod-perl script. smile Since it's not my server, I can not tell you the detail information. But the server's adminitrator told me that when he try your bbs, his server runs in a strange status.

3. When you use sql request, you'd better put $sth->prepare outsite loop. DBI's prepare need too many time and in most of enviroment, you do not need to do that. You can use $sth->execute($values) in the loop to run the sql request. I also found that you use a lot of $dbh->quote(),,, you can also use ? in the sql syntax and use execute(...) to replace them. Just a suggestion

4. Your old addpost.pl will lock in my window system, and some times, in linux server. I have replaced it with CGI.pm. (Your getfile function has some problems). Maybe you have fixed it.

5. When you upgrade your scripts, could you please give us the list of scripts you modified? I have modified a lot of your scripts. Everytime, you upgrade it and said there are some security bugs, I have to upgrade it and redo a lot of work...... smile It's not funny. :(

6. The bbs should has a digest features to store some good articles. If you do not do that, I have to write one by myself.

Ok, that's all. Keep your good job!

Billow


Sponsored Links

Link Copied to Clipboard
Donate Today!
Donate via PayPal

Donate to UBBDev today to help aid in Operational, Server and Script Maintenance, and Development costs.

Please also see our parent organization VNC Web Services if you're in the need of a new UBB.threads Install or Upgrade, Site/Server Migrations, or Security and Coding Services.
Recommended Hosts
We have personally worked with and recommend the following Web Hosts:
Stable Host
bluehost
InterServer
Visit us on Facebook
Member Spotlight
Bill B
Bill B
Issaquah, WA
Posts: 87
Joined: December 2001
Forum Statistics
Forums63
Topics37,573
Posts293,925
Members13,849
Most Online5,166
Sep 15th, 2019
Today's Statistics
Currently Online
Topics Created
Posts Made
Users Online
Birthdays
Top Posters
AllenAyres 21,079
JoshPet 10,369
LK 7,394
Lord Dexter 6,708
Gizmo 5,833
Greg Hard 4,625
Top Posters(30 Days)
Top Likes Received
isaac 82
Gizmo 20
Brett 7
WebGuy 2
Morgan 2
Top Likes Received (30 Days)
None yet
The UBB.Developers Network (UBB.Dev/Threads.Dev) is ©2000-2024 VNC Web Services

 
Powered by UBB.threads™ PHP Forum Software 8.0.0
(Preview build 20240430)