UBB.Developers Forums UBB.threads 6 V5.php Modifications Stuck preview mode

Well, I'm not sure what's happening with an official fix to the preview bug, but since people are still complaining about it, here's a "hack" fix for it....

============================================================================================

editdisplay.php

// Find out if they preview or not
if ($Preview == "on") { // *modify* (line 144)
$previewon = "selected";

============================================================================================

newreply.php and newpost.php

if ($user[U_EReplies] == "On"){
$Eselected = "checked";
}
if ($Preview == "on"){ // *modify* (line 46 in both files)
$Pselected = "checked";
}

============================================================================================

sendprivate.php

if (!$Preview) { $Preview = $config[Preview]; }

if ($Preview == "on"){ // *modify* (line 34)
$Pselected = "checked";
}

============================================================================================

mess_handler.php

// Let's find out if they get the default preview or not.
$Preview = $user[U_Preview];
if (!$Preview) { $Preview = $config[Preview]; }
if ($Preview == "on") { // *modify* (line 139)
$Pselected = "checked";
}

============================================================================================

Haven't released the official fix yet because this doesn't quite fall back to the default setting properly. It's close and should get everyone by until I can get the fallback code fixed as well.

Yes, I did notice that, but the problem is whether you are going to use a boolean value or the "on" and "off" values (since currently it's mixed). I would prefer that boolean values be used for all such variables and the variables defined in the MySQL database changed accordingly. In that case something like the following would be used for each file:

newreply.php
newpost.php
sendprivate.php
mess_handler.php
mess_reply.php

if ($Preview == NULL) {
$Preview = $config[preview];
}
if ($Preview) {
$Pselected = "checked";
}

=======================================================

and in editdisplay.php:

// Find out if they preview or not
if ($Preview == NULL) {
$Preview = $config[preview];
}
if ($Preview) {
$previewon = "selected";
}
else {
$previewoff = "selected";
}
------------------------------------------------------------------------------------
<select name = "Preview" class="formboxes">
<option value = "0" $previewoff>$lang[TEXT_OFF]</option>
<option value = "1" $previewon>$lang[TEXT_ON]</option>
</select>