UBB.Developers Forums UBB.threads 6 Bug Reports 5.4.3 Editing post reverts markup to html

After making a post with markup (only) enabled, and then editing it, the post reverts to HTML code. The HTML code then does not properly display it because HTML was not originally enabled. Example:

Make new post using markup:
[:red][i.mage]http://whatever.com/myimage.jpg[/i.mage]

The image shows up fine after I post. Now after editing the post I just made the markup reverts to HTML code:
[:red]<img src="http://whatever.com/myimage.jpg">

And it displays the HTML code instead of the image itself. The user must by hand convert all his HTML code to markup while editing the post.

This was a problem with 5.4.3. The original encoding of the post (markup/html) was not recorded properly with the post so it broke when editing.

...what that means is "please upgrade to 5.4.4 for a fix."

Rats... ok thanks. My 5.4.3 is heavily hacked. Is there a specific section of code you can point me to where I can incorporate the fix or is it fairly widespread and dependent on a larger scope of changes and additions?

The upgrade from 5.4.3 to 5.4.4 had some pretty hefty changes. Initially it was only in newpost and newreply, but to fully fix it involves those 2 files along with addpost, showflat and showthreaded.

My board, too, is heavily hacked.

One thing I've been doing to make upgrades smoother and less time-consuming is to always keep a local copy of W3T on my hard drive (the copy downloaded from here); when any of the PHP components are hacked a/o modified, I make a copy of the original script, and name the copy something like 'xyz.php (mod)' ... for instance, 'newpost.php' would be changed to 'newpost.php (mod)' ... but you can use any naming convention that works for you. The point is that, when looking in any of the W3T directories, at a glance you know exactly which scripts have been hacked, and consequently what needs to be modified when you download the latest upgrade.

I'm sure there are other, equally good approaches to tracking hacks; this method has (so far) served me well. Ultimately, you simply have to weigh the benefits of having the latest, improved version of W3T against what you're currently using. 5.4.3php had enough problems (and gave me enough headaches) that the choice was clear and compelling.